Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct list of dependency packages for perftest #303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion debian/control
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Vcs-Browser: http://git.openfabrics.org/git?p=~shamoya/perftest.git;a=summary

Package: perftest
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, libibverbs1 (>= 1.1.6), librdmacm1 (>=1.0.8)
Depends: ${shlibs:Depends}, ${misc:Depends}, libibverbs1 (>= 1.1.6), librdmacm1 (>=1.0.8), libibumad, rdma-core

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies on libraries are added automatically at build time. For instance, the deb package depends on libibumad3 as well as on some other rdma-core libraries (libibverbs1, and others). See https://packages.debian.org/sid/perftest .

Why doe sit need to depend on rdma-core?

Description: Infiniband verbs performance tests
This is a collection of tests written using Infiniband verbs intended for
use as a performance micro-benchmark. The tests can measure the latency
Expand Down
1 change: 1 addition & 0 deletions perftest.spec
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Url: http://www.openfabrics.org
BuildRoot: %{_tmppath}/%{name}-%{version}-build
BuildRequires: libibverbs-devel librdmacm-devel libibumad-devel
BuildRequires: pciutils-devel
Requires: libibverbs libibumad librdmacm libpci3 rdma-core

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comment: dependencies on libraries should be auto-generated. Dependency on rdma-core: why?


%description
gen3 uverbs microbenchmarks
Expand Down