Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set segment write timeout #51

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Set segment write timeout #51

merged 1 commit into from
Jan 25, 2024

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jan 25, 2024

Set segment write timeout to 5 min, the same is used in catalyst-api. The timeout flag was being set much too high.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (58cf59f) 17.57576% compared to head (2d73713) 17.57576%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                main         #51   +/-   ##
=============================================
  Coverage   17.57576%   17.57576%           
=============================================
  Files              2           2           
  Lines            165         165           
=============================================
  Hits              29          29           
  Misses           128         128           
  Partials           8           8           
Files Coverage Δ
core/uploader.go 23.20000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58cf59f...2d73713. Read the comment docs.

Files Coverage Δ
core/uploader.go 23.20000% <0.00000%> (ø)

@mjh1 mjh1 requested a review from thomshutt January 25, 2024 11:25
@mjh1 mjh1 merged commit 803ed70 into main Jan 25, 2024
10 checks passed
@mjh1 mjh1 deleted the mh/timeout branch January 25, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants