Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set segment write timeout #51

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Set segment write timeout #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/uploader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
return backoff.WithMaxRetries(newExponentialBackOffExecutor(), 3)
}

const segmentWriteTimeout = 5 * time.Minute

func Upload(input io.Reader, outputURI string, waitBetweenWrites, writeTimeout time.Duration) error {
storageDriver, err := drivers.ParseOSURL(outputURI, true)
if err != nil {
Expand Down Expand Up @@ -60,7 +62,7 @@
}

err = backoff.Retry(func() error {
_, err := session.SaveData(context.Background(), "", bytes.NewReader(fileContents), fields, writeTimeout)
_, err := session.SaveData(context.Background(), "", bytes.NewReader(fileContents), fields, segmentWriteTimeout)

Check warning on line 65 in core/uploader.go

View check run for this annotation

Codecov / codecov/patch

core/uploader.go#L65 

Added line #L65 was not covered by tests
if err != nil {
glog.Errorf("failed upload attempt: %v", err)
}
Expand Down
Loading