-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update test workflow to ubuntu 20.04 #2841
update test workflow to ubuntu 20.04 #2841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we should also consider bumping our build pipeline to ubuntu 20 (or 22?)! wdyt @leszko / @thomshutt
https://github.com/livepeer/go-livepeer/blob/master/.github/workflows/build.yaml#L19-L20
.github/workflows/test.yaml
Outdated
steps: | ||
- name: Setup ubuntu container | ||
run: | | ||
apt update | ||
export TZ=Etc/Utc | ||
ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone | ||
export DEBIAN_FRONTEND=noninteractive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my experience, github workflows work better if instead of export
, we do one of:
echo TZ=Etc/UTC >> $GITHUB_ENV
or specify it in the job itself:
env:
TZ: "Etc/UTC"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have "fixed" this by removing it as part of a larger change to moving from ubuntu-latest
with ubuntu:18.04
container specified to using runs-on: ubuntu-20.04
.
Codecov Report
@@ Coverage Diff @@
## master #2841 +/- ##
===================================================
- Coverage 56.72881% 56.71314% -0.01567%
===================================================
Files 88 88
Lines 19149 19149
===================================================
- Hits 10863 10860 -3
- Misses 7690 7693 +3
Partials 596 596 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
If it's not too much work then definitely! |
hey @ad-astra-video ; i've created a new PR which bumps our ubuntu versions for build workflow as well: #2846 i've forked off from your branch! closing this PR in favour of that one. thanks for your contribution |
What does this pull request do? Explain your changes. (required)
Updates test workflow to use ubuntu 20.04
Specific updates (required)
How did you test each of these updates (required)
Ran on my fork of go-livepeer https://github.com/ad-astra-video/go-livepeer/actions/runs/5887219287
Does this pull request close any open issues?
No
Checklist:
make
runs successfully./test.sh
pass