Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test workflow to ubuntu 20.04 #2841

Closed

Conversation

ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)
Updates test workflow to use ubuntu 20.04

Specific updates (required)

  • bumped ubuntu version to 20.04
  • used Dockerfile to update installation steps
  • removed folders not needed to create space on runner

How did you test each of these updates (required)
Ran on my fork of go-livepeer https://github.com/ad-astra-video/go-livepeer/actions/runs/5887219287

Does this pull request close any open issues?
No

Checklist:

@leszko leszko requested a review from hjpotter92 August 18, 2023 06:26
Copy link
Member

@hjpotter92 hjpotter92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we should also consider bumping our build pipeline to ubuntu 20 (or 22?)! wdyt @leszko / @thomshutt
https://github.com/livepeer/go-livepeer/blob/master/.github/workflows/build.yaml#L19-L20

steps:
- name: Setup ubuntu container
run: |
apt update
export TZ=Etc/Utc
ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
export DEBIAN_FRONTEND=noninteractive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my experience, github workflows work better if instead of export, we do one of:

echo TZ=Etc/UTC >> $GITHUB_ENV

or specify it in the job itself:

env:
  TZ: "Etc/UTC"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have "fixed" this by removing it as part of a larger change to moving from ubuntu-latest with ubuntu:18.04 container specified to using runs-on: ubuntu-20.04.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #2841 (db0421f) into master (3f62408) will decrease coverage by 0.01567%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2841         +/-   ##
===================================================
- Coverage   56.72881%   56.71314%   -0.01567%     
===================================================
  Files             88          88                 
  Lines          19149       19149                 
===================================================
- Hits           10863       10860          -3     
- Misses          7690        7693          +3     
  Partials         596         596                 

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f62408...db0421f. Read the comment docs.

see 1 file with indirect coverage changes

@thomshutt
Copy link
Contributor

perhaps we should also consider bumping our build pipeline to ubuntu 20 (or 22?)! wdyt @leszko / @thomshutt
https://github.com/livepeer/go-livepeer/blob/master/.github/workflows/build.yaml#L19-L20

If it's not too much work then definitely!

@hjpotter92
Copy link
Member

hey @ad-astra-video ; i've created a new PR which bumps our ubuntu versions for build workflow as well: #2846

i've forked off from your branch! closing this PR in favour of that one.

thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants