Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test and build workflows to ubuntu 20.04 #2846

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Conversation

hjpotter92
Copy link
Member

@hjpotter92 hjpotter92 commented Aug 24, 2023

What does this pull request do? Explain your changes. (required)
Updates test and build workflows to use ubuntu 20.04

Specific updates (required)

  • bumped ubuntu version to 20.04
  • used Dockerfile to update installation steps
  • removed folders not needed to create space on runner

How did you test each of these updates (required)
this PR workflow runs

Does this pull request close any open issues?
old PR this one is based off on: #2841

Checklist:

@@ -81,16 +83,16 @@ jobs:

- name: Install dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to merge it with Setup ubuntu container step?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 'setup ubuntu container' was (and probably is) a temporary step i had to add since github had removed support for ubuntu-18 runners. i do not think we need that step, but just keeping it for future when ubuntu 20 support might go away and we might need to readd the

    container:
      image: ubuntu:18.04

directive for ubuntu-20 :|

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #2846 (36f5e35) into master (a231510) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 4.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #2846   +/-   ##
=============================================
  Coverage   56.70668%   56.70668%           
=============================================
  Files             88          88           
  Lines          19160       19160           
=============================================
  Hits           10865       10865           
  Misses          7699        7699           
  Partials         596         596           
Files Changed Coverage Δ
cmd/livepeer/livepeer.go 47.61905% <0.00000%> (ø)
cmd/livepeer/starter/starter.go 4.26288% <0.00000%> (ø)
cmd/livepeer_cli/wizard_bond.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_rounds.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_stats.go 0.00000% <0.00000%> (ø)
verification/verify.go 89.16667% <100.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f350fba...36f5e35. Read the comment docs.

Files Changed Coverage Δ
cmd/livepeer/livepeer.go 47.61905% <0.00000%> (ø)
cmd/livepeer/starter/starter.go 4.26288% <0.00000%> (ø)
cmd/livepeer_cli/wizard_bond.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_rounds.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_stats.go 0.00000% <0.00000%> (ø)
verification/verify.go 89.16667% <100.00000%> (ø)

@thomshutt
Copy link
Contributor

Massively in favour of this! Looks like the build is failing at the moment though

run: |
go install github.com/golang/protobuf/[email protected]
sudo apt update
sudo apt install -yqq protobuf-compiler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be merged with setup ubuntu container?

@hjpotter92 hjpotter92 force-pushed the hjp/build-workflow branch 3 times, most recently from 5de0eb5 to 257e432 Compare August 24, 2023 17:15
@hjpotter92 hjpotter92 force-pushed the hjp/build-workflow branch 3 times, most recently from b7b6003 to 8cd4f74 Compare August 25, 2023 04:05
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment. It's fine with me, but please with merging to resolve all discussions and comments from @pwilczynskiclearcode

@@ -277,21 +284,23 @@ jobs:
key: ${{ runner.os }}-binaries-tf-${{ github.sha }}

- name: Install dependencies
env:
LIBTENSORFLOW_VERSION: "2.12.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still use tensorflow? Don't want to get rid of it everywhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if we can tear it out without breaking builds then let's do it. I started trying in #2836 but haven't had time to finish it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! that requires quite a lot of changes in go code... which i'd rather not touch in this small-ish PR. would rather bump 2836 with changes from this PR and keep tensorflow removal over in that alone.

@hjpotter92 hjpotter92 merged commit 98716b5 into master Aug 31, 2023
17 checks passed
@hjpotter92 hjpotter92 deleted the hjp/build-workflow branch August 31, 2023 07:27
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants