Add center_point_box=1 support in NonMaxSuppression. #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vivekkhandelwal1 @jinchen62 Looks like I don't have permission to add reviewers, could you please take a look? |
jinchen62
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Thanks for making this! LGTM except for some minor changes.
Could you test iree e2e test https://github.com/iree-org/iree-test-suites/tree/main/onnx_ops/onnx/node/generated/test_nonmaxsuppression_center_point_box_format? If you haven't used it, instruction is here https://github.com/iree-org/iree-test-suites/blob/main/onnx_ops/README.md.
When center_point_box=1, the supplied boxes come with a format of [x_center, y_center, width, height], this patch converts the format into [x1, y1, x2, y2] format before they are consumed.
lpy
force-pushed
the
nonmaxsuppression
branch
from
d7603ab to
7487082
Compare
|
Thanks for the guidance. Comments addressed. I have also confirmed PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When center_point_box=1, the supplied boxes come with a format of [x_center, y_center, width, height], this patch converts the format into [x1, y1, x2, y2] format before they are consumed.
The e2e test is added in nod-ai/SHARK-TestSuite#436