Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cloud shell #780

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Support cloud shell #780

merged 2 commits into from
Sep 21, 2023

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Sep 21, 2023

This PR allows to use dftimewolf with the Google Cloud shell:

  • Allow python version 3.9 usage
  • Update pytype version to 2023.09.19
  • Modify some type checks to work with python3.9 by using Optional[] instead of the | operator.

@tomchop
Copy link
Collaborator

tomchop commented Sep 21, 2023

pytype is complaining about code in setup.py which we should clean up anyway. Merging

@tomchop tomchop merged commit 58e2574 into log2timeline:main Sep 21, 2023
6 of 7 checks passed
@jkppr jkppr deleted the support_cloud_shell branch September 21, 2023 15:08
@jkppr jkppr mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants