Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cloud shell #780

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Support cloud shell #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9665dd9
make dftw Cloud shell compatible
jkppr Sep 21, 2023
2bd1ae6
Adapt type checks to work with python 3.9
jkppr Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dftimewolf/lib/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import datetime
from dataclasses import dataclass
import logging
from typing import Dict, Any, List, Union
from typing import Dict, Any, List, Union, Optional
import uuid as uuid_lib

from dftimewolf import config
Expand Down Expand Up @@ -38,7 +38,7 @@ class TelemetryCollection:
class BaseTelemetry():
"""Interface for implementing a telemetry module."""

def __init__(self, uuid: str | None = None) -> None:
def __init__(self, uuid: Optional[str] = None) -> None:
"""Initializes a BaseTelemetry object."""
super().__init__()
self.uuid = uuid
Expand Down Expand Up @@ -77,7 +77,7 @@ def __init__(
project_name: str,
instance_name: str,
database_name: str,
uuid: str | None = None) -> None:
uuid: Optional[str] = None) -> None:
"""Initializes a GoogleCloudSpannerTelemetry object."""
super().__init__(uuid=uuid)
self.project_name = project_name
Expand Down Expand Up @@ -163,7 +163,7 @@ def _LogTelemetryTransaction(


def GetTelemetry(
uuid: str | None = None
uuid: Optional[str] = None
) -> Union[BaseTelemetry, GoogleCloudSpannerTelemetry]:
"""Returns the currently configured Telemetry object."""
telemetry_config = config.Config.GetExtra('telemetry')
Expand Down
Loading
Loading