Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris: Add clear chat session button #6894

Merged
merged 139 commits into from
Jul 18, 2023
Merged

Conversation

dakennguyen
Copy link

@dakennguyen dakennguyen commented Jul 13, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

  • I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
  • I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

Add clear chat history button. In the background, it will call API from the server to create a new session

Description

  • Add a new button and call API on click

Steps for Testing

Prerequisites:

  • 1 Student
  • 1 Programming Exercise with Iris enabled
  1. Log in to Artemis
  2. Navigate to a programming exercise with Iris enabled
  3. Chat something and then click on the Trash button
  4. Click submit on the confirm modal
  5. Your chat history should disappear and you can chat with the new context
  6. The trash button is disappear
  7. Refresh the page, accept the policy, and even with Iris welcome message the trash button still disappears

It should be able to work on all sizes of the chatbot

Exam Mode Testing

Review Progress

Performance Review

  • I confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

image

image

@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 18, 2023
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
12 tasks
@DemjenDavid DemjenDavid added the deploy:artemis-test9 Testserver for Project Theia label Jul 18, 2023
@DemjenDavid DemjenDavid temporarily deployed to artemis-test9.artemis.cit.tum.de July 18, 2023 11:31 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 18, 2023
@DemjenDavid DemjenDavid added deploy:artemis-test9 Testserver for Project Theia and removed lock:artemis-test9 labels Jul 18, 2023
@DemjenDavid DemjenDavid temporarily deployed to artemis-test9.artemis.cit.tum.de July 18, 2023 11:39 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 18, 2023
@github-actions
Copy link

❌ Unable to deploy to test servers ❌

Testserver "artemis-test9.artemis.cit.tum.de" is already in use by PR #6931.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Jul 18, 2023
@bassner bassner added deploy:artemis-test9 Testserver for Project Theia and removed deployment-error Added by deployment workflows if an error occured labels Jul 18, 2023
@bassner bassner temporarily deployed to artemis-test9.artemis.cit.tum.de July 18, 2023 15:59 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 18, 2023
@bassner bassner merged commit 21e8fb5 into develop-iris Jul 18, 2023
31 of 38 checks passed
@bassner bassner deleted the feature/clear-chat-session-ui branch July 18, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) component:Iris ready for review tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.