Lecture: Allow instructors to remove solution slides when processing units
#6895
Teamscale / teamscale-findings
required action
Jul 28, 2023 in 0s
Teamscale
This pull request would introduce 7 new findings
Details
- src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitIntegrationTest.java#131: Clone with 2 instances of length 13 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java#117: Statements in Conditional Expression are equal (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#255: Violation of nesting depth threshold of 3: 4 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java#120: Statements in Conditional Expression are equal (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#180: Clone with 3 instances of length 10 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#179: Method
splitLectureFile_asInstructor_shouldRemoveSolutionSlides_and_removeBreakSlidesviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#238: Clone with 2 instances of length 13 (view in Teamscale)
Annotations
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java#L117
Statements in Conditional Expression are equal
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fremove-solution-slides%3AHEAD&id=4550D7B64DFB214A8B491E90EB4C70F2
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java#L120
Statements in Conditional Expression are equal
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fremove-solution-slides%3AHEAD&id=B332CE47A6FFAEFE33DC5ABAFDCA8AD7
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L255-L267
This method is a bit lengthy [0] and deeply nested in multiple places [1, 2, 3] which can make it hard to understand and maintain. Consider extracting helper methods or reducing the nesting by using early breaks or returns.
[0] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fremove-solution-slides%3AHEAD&id=58F014C2BE72AFC421B170242789C78A
[1] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fremove-solution-slides%3AHEAD&id=8C12B73771ADE5E7462437CE8A7CC72E
[2] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fremove-solution-slides%3AHEAD&id=8B275A51C6264D1544AEECE5158AFD28
[3] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fremove-solution-slides%3AHEAD&id=596FAA0A2084B6C5F4DD8DF99E590B8E
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L180-L194
Clone with 3 instances of length 10
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fremove-solution-slides%3AHEAD&id=4A23D5B88955B75EA3150273DD76C250
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L179
Method `splitLectureFile_asInstructor_shouldRemoveSolutionSlides_and_removeBreakSlides` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fremove-solution-slides%3AHEAD&id=D1A876899A6DF40483B0139E7B0730D9
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L238-L252
Clone with 2 instances of length 13
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fremove-solution-slides%3AHEAD&id=D875A33EAE8EB7D0879F06D566C5D73B
Loading