Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris: Add about-iris link in first message #6917

Merged
merged 19 commits into from
Jul 18, 2023

Conversation

RY997
Copy link
Contributor

@RY997 RY997 commented Jul 16, 2023

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

Add about-iris link in first greeting message

Description

Attach about-iris link to "here" in first message

Steps for Testing

Prerequisites:

  • 1 Student
  • 1 new Programming Exercise with Iris enabled
  1. Log in to Artemis
  2. Navigate to Programming exercise
  3. Open Iris and click "here" in first message, go to About Iris page

Review Progress

Performance Review

  • I confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Screenshots

@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) labels Jul 16, 2023
@github-actions github-actions bot removed the server Pull requests that update Java code. (Added Automatically!) label Jul 16, 2023
@RY997 RY997 added the deploy:artemis-test9 Testserver for Project Theia label Jul 16, 2023
@RY997 RY997 temporarily deployed to artemis-test9.artemis.cit.tum.de July 16, 2023 21:16 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 16, 2023
@RY997 RY997 added the deploy:artemis-test9 Testserver for Project Theia label Jul 16, 2023
@RY997 RY997 temporarily deployed to artemis-test9.artemis.cit.tum.de July 16, 2023 22:58 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 16, 2023
@RY997 RY997 added the deploy:artemis-test9 Testserver for Project Theia label Jul 16, 2023
@github-actions github-actions bot removed the deploy:artemis-test9 Testserver for Project Theia label Jul 16, 2023
@github-actions
Copy link

❌ Unable to deploy to test servers ❌

Testserver "artemis-test9.artemis.cit.tum.de" is already in use by PR #6894.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Jul 16, 2023
@RY997 RY997 removed the deployment-error Added by deployment workflows if an error occured label Jul 16, 2023
@RY997 RY997 temporarily deployed to artemis-test9.artemis.cit.tum.de July 17, 2023 17:13 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 17, 2023
@github-actions github-actions bot mentioned this pull request Jul 17, 2023
12 tasks
@eceeeren eceeeren added the deploy:artemis-test9 Testserver for Project Theia label Jul 17, 2023
@eceeeren eceeeren temporarily deployed to artemis-test9.artemis.cit.tum.de July 17, 2023 18:47 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 17, 2023
@asliayk asliayk added deploy:artemis-test9 Testserver for Project Theia and removed lock:artemis-test9 labels Jul 17, 2023
@RY997 RY997 removed the deploy:artemis-test9 Testserver for Project Theia label Jul 17, 2023
@asliayk asliayk added the deploy:artemis-test9 Testserver for Project Theia label Jul 17, 2023
@github-actions github-actions bot added deployment-error Added by deployment workflows if an error occured and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 17, 2023
@asliayk asliayk added the deploy:artemis-test9 Testserver for Project Theia label Jul 17, 2023
@ls1intum ls1intum deleted a comment from github-actions bot Jul 17, 2023
@github-actions github-actions bot removed the deployment-error Added by deployment workflows if an error occured label Jul 17, 2023
@asliayk asliayk temporarily deployed to artemis-test9.artemis.cit.tum.de July 17, 2023 21:51 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 17, 2023
Copy link
Contributor

@asliayk asliayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ts9, works fine!

Copy link

@SolizerCodes SolizerCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts9, first message works well 👍

@bassner bassner merged commit eff0c8d into feature/accept-iris-ui Jul 18, 2023
32 of 40 checks passed
@bassner bassner deleted the feature/aboutiris-in-firstmsg branch July 18, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) component:Iris ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants