`Exam mode`: Fix displaying incorrect task in exam summary exercise #9294

SimonEntholzer · 2024-09-06T20:29:28Z

Checklist

General

I tested all changes and their related features with all corresponding user types on a test server.
This is a small issue that I tested locally and was confirmed by another developer on a test server.
I chose a title conforming to the naming conventions for pull requests.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the client coding and design guidelines.
Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Fixes #9253

Description

Since the task's css class was only distinguishable by task id, but not by the exercise they belonged to, all tasks where just replaced by the tasks of the last exercise. By adding the exercise id in the css class, the tasks show up correctly again in the problem statement.

Steps for Testing (Exam Mode Testing)

See issue #9253.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

Code Review 1
Code Review 2

Test / Exam Mode Test

Test 1
Test 2

Test Coverage

Screenshots

Before fix:

After fix:

Summary by CodeRabbit

New Features
- Enhanced task identifiers for unique identification across multiple exercises.
- Improved visual feedback for sorting algorithm tasks with dynamic status indicators and icons.
- Updated HTML structure for clearer representation of task execution status.
- Consistent styling and behavior across problem statements for better maintainability.
Bug Fixes
- Resolved potential conflicts in task identifier rendering when multiple exercises are displayed.

SimonEntholzer · 2024-09-06T20:32:33Z

src/test/javascript/spec/helpers/sample/problemStatement.json

@@ -7,8 +7,8 @@
    "problemStatementBothFailedRendered": "<ol>\n<li><span class=\"bold\"><span id=step-icon-0></span> Implement Bubble Sort</span>: <span class=\"text-danger bold\">artemisApp.editor.testStatusLabels.noResult</span><br>\nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>BubbleSort</code>. Make sure to follow the Bubble Sort algorithm exactly.</li>\n<li><span class=\"bold\"><span id=step-icon-1></span> Implement Merge Sort</span>: <span class=\"text-danger bold\">artemisApp.editor.testStatusLabels.noResult</span><br>\nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>MergeSort</code>. Make sure to follow the Merge Sort algorithm exactly.</li>\n</ol>\n",
    "problemStatementBothFailedHtml": "<ol>\n<li><span class=\"bold\"><span id=\"step-icon-0\"><fa-icon class=\"ng-fa-icon\"><svg aria-hidden=\"true\" focusable=\"false\" data-prefix=\"far\" data-icon=\"times-circle\" class=\"svg-inline--fa fa-times-circle fa-w-16 fa-lg text-danger\" role=\"img\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 8C119 8 8 119 8 256s111 248 248 248 248-111 248-248S393 8 256 8zm0 448c-110.5 0-200-89.5-200-200S145.5 56 256 56s200 89.5 200 200-89.5 200-200 200zm101.8-262.2L295.6 256l62.2 62.2c4.7 4.7 4.7 12.3 0 17l-22.6 22.6c-4.7 4.7-12.3 4.7-17 0L256 295.6l-62.2 62.2c-4.7 4.7-12.3 4.7-17 0l-22.6-22.6c-4.7-4.7-4.7-12.3 0-17l62.2-62.2-62.2-62.2c-4.7-4.7-4.7-12.3 0-17l22.6-22.6c4.7-4.7 12.3-4.7 17 0l62.2 62.2 62.2-62.2c4.7-4.7 12.3-4.7 17 0l22.6 22.6c4.7 4.7 4.7 12.3 0 17z\"></path></svg></fa-icon></span> Implement Bubble Sort</span>: <a data-tests=\"testBubbleSort\" class=\"test-status\"><span class=\"text-danger result\">artemisApp.editor.testStatusLabels.testFailing</span></a><br>\nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>BubbleSort</code>. Make sure to follow the Bubble Sort algorithm exactly.</li>\n<li><span class=\"bold\"><span id=\"step-icon-1\"><fa-icon class=\"ng-fa-icon\"><svg aria-hidden=\"true\" focusable=\"false\" data-prefix=\"far\" data-icon=\"check-circle\" class=\"svg-inline--fa fa-check-circle fa-w-16 fa-lg text-success\" role=\"img\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 8C119.033 8 8 119.033 8 256s111.033 248 248 248 248-111.033 248-248S392.967 8 256 8zm0 48c110.532 0 200 89.451 200 200 0 110.532-89.451 200-200 200-110.532 0-200-89.451-200-200 0-110.532 89.451-200 200-200m140.204 130.267l-22.536-22.718c-4.667-4.705-12.265-4.736-16.97-.068L215.346 303.697l-59.792-60.277c-4.667-4.705-12.265-4.736-16.97-.069l-22.719 22.536c-4.705 4.667-4.736 12.265-.068 16.971l90.781 91.516c4.667 4.705 12.265 4.736 16.97.068l172.589-171.204c4.704-4.668 4.734-12.266.067-16.971z\"></path></svg></fa-icon></span> Implement Merge Sort</span>: <span class=\"text-success bold\">artemisApp.editor.testStatusLabels.testPassing</span><br>\nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>MergeSort</code>. Make sure to follow the Merge Sort algorithm exactly.</li>\n</ol>\n",
    "problemStatementBubbleSortFailsRendered": "<ol>\n<li><span class=\"bold\"><span id=step-icon-0></span> Implement Bubble Sort</span>: <span class=\"text-danger bold\">artemisApp.editor.testStatusLabels.noResult</span><br>\nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>BubbleSort</code>. Make sure to follow the Bubble Sort algorithm exactly.</li>\n<li><span class=\"bold\"><span id=step-icon-1></span> Implement Merge Sort</span>: <span class=\"text-danger bold\">artemisApp.editor.testStatusLabels.noResult</span><br>\nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>MergeSort</code>. Make sure to follow the Merge Sort algorithm exactly.</li>\n</ol>\n",
-    "problemStatementBubbleSortNotExecutedHtml": "<ol>\n<li><div class=\"pe-task-0 d-flex\" ng-version=\"{{ANGULAR_VERSION}}\"><div class=\"guided-tour\"><!--container--><!--container--><fa-icon size=\"lg\" class=\"ng-fa-icon test-icon text-secondary\" ng-reflect-size=\"lg\" ng-reflect-icon=\"[object Object]\"><svg role=\"img\" aria-hidden=\"true\" focusable=\"false\" data-prefix=\"fas\" data-icon=\"circle-question\" class=\"svg-inline--fa fa-circle-question fa-lg\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 512A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM169.8 165.3c7.9-22.3 29.1-37.3 52.8-37.3l58.3 0c34.9 0 63.1 28.3 63.1 63.1c0 22.6-12.1 43.5-31.7 54.8L280 264.4c-.2 13-10.9 23.6-24 23.6c-13.3 0-24-10.7-24-24l0-13.5c0-8.6 4.6-16.5 12.1-20.8l44.3-25.4c4.7-2.7 7.6-7.7 7.6-13.1c0-8.4-6.8-15.1-15.1-15.1l-58.3 0c-3.4 0-6.4 2.1-7.5 5.3l-.4 1.2c-4.4 12.5-18.2 19-30.6 14.6s-19-18.2-14.6-30.6l.4-1.2zM224 352a32 32 0 1 1 64 0 32 32 0 1 1 -64 0z\"></path></svg></fa-icon><!--container--><span class=\"task-name\">Implement Bubble Sort</span><!--container--><span class=\"guided-tour test-status--linked text-secondary\">artemisApp.editor.testStatusLabels.totalTestsPassing: [{\"totalTests\":1,\"passedTests\":0}]</span><!--container--><!--container--></div></div> \nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>BubbleSort</code>. Make sure to follow the Bubble Sort algorithm exactly. </li>\n<li><div class=\"pe-task-1 d-flex\" ng-version=\"{{ANGULAR_VERSION}}\"><div class=\"guided-tour success\"><fa-icon size=\"lg\" class=\"ng-fa-icon test-icon text-success\" ng-reflect-size=\"lg\" ng-reflect-icon=\"[object Object]\"><svg role=\"img\" aria-hidden=\"true\" focusable=\"false\" data-prefix=\"far\" data-icon=\"circle-check\" class=\"svg-inline--fa fa-circle-check fa-lg\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 48a208 208 0 1 1 0 416 208 208 0 1 1 0-416zm0 464A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM369 209c9.4-9.4 9.4-24.6 0-33.9s-24.6-9.4-33.9 0l-111 111-47-47c-9.4-9.4-24.6-9.4-33.9 0s-9.4 24.6 0 33.9l64 64c9.4 9.4 24.6 9.4 33.9 0L369 209z\"></path></svg></fa-icon><!--container--><!--container--><!--container--><span class=\"task-name\">Implement Merge Sort</span><!--container--><span class=\"guided-tour test-status--linked text-success\">artemisApp.editor.testStatusLabels.totalTestsPassing: [{\"totalTests\":1,\"passedTests\":1}]</span><!--container--><!--container--></div></div> \nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>MergeSort</code>. Make sure to follow the Merge Sort algorithm exactly.</li>\n</ol>",
+    "problemStatementBubbleSortNotExecutedHtml": "<ol>\n<li><div class=\"pe-3-task-0 d-flex\" ng-version=\"{{ANGULAR_VERSION}}\"><div class=\"guided-tour\"><!--container--><!--container--><fa-icon size=\"lg\" class=\"ng-fa-icon test-icon text-secondary\" ng-reflect-size=\"lg\" ng-reflect-icon=\"[object Object]\"><svg role=\"img\" aria-hidden=\"true\" focusable=\"false\" data-prefix=\"fas\" data-icon=\"circle-question\" class=\"svg-inline--fa fa-circle-question fa-lg\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 512A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM169.8 165.3c7.9-22.3 29.1-37.3 52.8-37.3l58.3 0c34.9 0 63.1 28.3 63.1 63.1c0 22.6-12.1 43.5-31.7 54.8L280 264.4c-.2 13-10.9 23.6-24 23.6c-13.3 0-24-10.7-24-24l0-13.5c0-8.6 4.6-16.5 12.1-20.8l44.3-25.4c4.7-2.7 7.6-7.7 7.6-13.1c0-8.4-6.8-15.1-15.1-15.1l-58.3 0c-3.4 0-6.4 2.1-7.5 5.3l-.4 1.2c-4.4 12.5-18.2 19-30.6 14.6s-19-18.2-14.6-30.6l.4-1.2zM224 352a32 32 0 1 1 64 0 32 32 0 1 1 -64 0z\"></path></svg></fa-icon><!--container--><span class=\"task-name\">Implement Bubble Sort</span><!--container--><span class=\"guided-tour test-status--linked text-secondary\">artemisApp.editor.testStatusLabels.totalTestsPassing: [{\"totalTests\":1,\"passedTests\":0}]</span><!--container--><!--container--></div></div> \nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>BubbleSort</code>. Make sure to follow the Bubble Sort algorithm exactly. </li>\n<li><div class=\"pe-3-task-1 d-flex\" ng-version=\"{{ANGULAR_VERSION}}\"><div class=\"guided-tour success\"><fa-icon size=\"lg\" class=\"ng-fa-icon test-icon text-success\" ng-reflect-size=\"lg\" ng-reflect-icon=\"[object Object]\"><svg role=\"img\" aria-hidden=\"true\" focusable=\"false\" data-prefix=\"far\" data-icon=\"circle-check\" class=\"svg-inline--fa fa-circle-check fa-lg\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 48a208 208 0 1 1 0 416 208 208 0 1 1 0-416zm0 464A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM369 209c9.4-9.4 9.4-24.6 0-33.9s-24.6-9.4-33.9 0l-111 111-47-47c-9.4-9.4-24.6-9.4-33.9 0s-9.4 24.6 0 33.9l64 64c9.4 9.4 24.6 9.4 33.9 0L369 209z\"></path></svg></fa-icon><!--container--><!--container--><!--container--><span class=\"task-name\">Implement Merge Sort</span><!--container--><span class=\"guided-tour test-status--linked text-success\">artemisApp.editor.testStatusLabels.totalTestsPassing: [{\"totalTests\":1,\"passedTests\":1}]</span><!--container--><!--container--></div></div> \nImplement the method <code>performSort(List&lt;Date&gt;)</code> in the class <code>MergeSort</code>. Make sure to follow the Merge Sort algorithm exactly.</li>\n</ol>",


the only change here is changing "pe-task-0" to "pe-3-task-0" (programming exercise with id 3, and task with id 0) and "pe-task-1" to "pe-3-task-1"

SimonEntholzer · 2024-09-06T20:33:09Z

src/test/javascript/spec/helpers/sample/problemStatement.json

    "problemStatementEmptySecondTask": "1. [task][Bubble Sort](<testid>1</testid>) \n Implement the method. \n 2. [task][Merge Sort]() \n Implement the method.",
-    "problemStatementEmptySecondTaskNotExecutedHtml": "<ol>\n<li><div class=\"pe-task-0 d-flex\" ng-version=\"{{ANGULAR_VERSION}}\"><div class=\"guided-tour success\"><fa-icon size=\"lg\" class=\"ng-fa-icon test-icon text-success\" ng-reflect-size=\"lg\" ng-reflect-icon=\"[object Object]\"><svg role=\"img\" aria-hidden=\"true\" focusable=\"false\" data-prefix=\"far\" data-icon=\"circle-check\" class=\"svg-inline--fa fa-circle-check fa-lg\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 48a208 208 0 1 1 0 416 208 208 0 1 1 0-416zm0 464A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM369 209c9.4-9.4 9.4-24.6 0-33.9s-24.6-9.4-33.9 0l-111 111-47-47c-9.4-9.4-24.6-9.4-33.9 0s-9.4 24.6 0 33.9l64 64c9.4 9.4 24.6 9.4 33.9 0L369 209z\"></path></svg></fa-icon><!--container--><!--container--><!--container--><span class=\"task-name\">Bubble Sort</span><!--container--><span class=\"guided-tour test-status--linked text-success\">artemisApp.editor.testStatusLabels.totalTestsPassing: [{\"totalTests\":1,\"passedTests\":1}]</span><!--container--><!--container--></div></div> \nImplement the method. </li>\n<li><div class=\"pe-task-1 d-flex\" ng-version=\"{{ANGULAR_VERSION}}\"><div class=\"guided-tour\"><!--container--><!--container--><fa-icon size=\"lg\" class=\"ng-fa-icon test-icon text-secondary\" ng-reflect-size=\"lg\" ng-reflect-icon=\"[object Object]\"><svg role=\"img\" aria-hidden=\"true\" focusable=\"false\" data-prefix=\"fas\" data-icon=\"circle-question\" class=\"svg-inline--fa fa-circle-question fa-lg\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 512A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM169.8 165.3c7.9-22.3 29.1-37.3 52.8-37.3l58.3 0c34.9 0 63.1 28.3 63.1 63.1c0 22.6-12.1 43.5-31.7 54.8L280 264.4c-.2 13-10.9 23.6-24 23.6c-13.3 0-24-10.7-24-24l0-13.5c0-8.6 4.6-16.5 12.1-20.8l44.3-25.4c4.7-2.7 7.6-7.7 7.6-13.1c0-8.4-6.8-15.1-15.1-15.1l-58.3 0c-3.4 0-6.4 2.1-7.5 5.3l-.4 1.2c-4.4 12.5-18.2 19-30.6 14.6s-19-18.2-14.6-30.6l.4-1.2zM224 352a32 32 0 1 1 64 0 32 32 0 1 1 -64 0z\"></path></svg></fa-icon><!--container--><span class=\"task-name\">Merge Sort</span><!--container--><!--container--><span class=\"text-secondary\">artemisApp.editor.testStatusLabels.noTests</span><!--container--></div></div> \nImplement the method.</li>\n</ol>",
+    "problemStatementEmptySecondTaskNotExecutedHtml": "<ol>\n<li><div class=\"pe-3-task-0 d-flex\" ng-version=\"{{ANGULAR_VERSION}}\"><div class=\"guided-tour success\"><fa-icon size=\"lg\" class=\"ng-fa-icon test-icon text-success\" ng-reflect-size=\"lg\" ng-reflect-icon=\"[object Object]\"><svg role=\"img\" aria-hidden=\"true\" focusable=\"false\" data-prefix=\"far\" data-icon=\"circle-check\" class=\"svg-inline--fa fa-circle-check fa-lg\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 48a208 208 0 1 1 0 416 208 208 0 1 1 0-416zm0 464A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM369 209c9.4-9.4 9.4-24.6 0-33.9s-24.6-9.4-33.9 0l-111 111-47-47c-9.4-9.4-24.6-9.4-33.9 0s-9.4 24.6 0 33.9l64 64c9.4 9.4 24.6 9.4 33.9 0L369 209z\"></path></svg></fa-icon><!--container--><!--container--><!--container--><span class=\"task-name\">Bubble Sort</span><!--container--><span class=\"guided-tour test-status--linked text-success\">artemisApp.editor.testStatusLabels.totalTestsPassing: [{\"totalTests\":1,\"passedTests\":1}]</span><!--container--><!--container--></div></div> \nImplement the method. </li>\n<li><div class=\"pe-3-task-1 d-flex\" ng-version=\"{{ANGULAR_VERSION}}\"><div class=\"guided-tour\"><!--container--><!--container--><fa-icon size=\"lg\" class=\"ng-fa-icon test-icon text-secondary\" ng-reflect-size=\"lg\" ng-reflect-icon=\"[object Object]\"><svg role=\"img\" aria-hidden=\"true\" focusable=\"false\" data-prefix=\"fas\" data-icon=\"circle-question\" class=\"svg-inline--fa fa-circle-question fa-lg\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\"><path fill=\"currentColor\" d=\"M256 512A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM169.8 165.3c7.9-22.3 29.1-37.3 52.8-37.3l58.3 0c34.9 0 63.1 28.3 63.1 63.1c0 22.6-12.1 43.5-31.7 54.8L280 264.4c-.2 13-10.9 23.6-24 23.6c-13.3 0-24-10.7-24-24l0-13.5c0-8.6 4.6-16.5 12.1-20.8l44.3-25.4c4.7-2.7 7.6-7.7 7.6-13.1c0-8.4-6.8-15.1-15.1-15.1l-58.3 0c-3.4 0-6.4 2.1-7.5 5.3l-.4 1.2c-4.4 12.5-18.2 19-30.6 14.6s-19-18.2-14.6-30.6l.4-1.2zM224 352a32 32 0 1 1 64 0 32 32 0 1 1 -64 0z\"></path></svg></fa-icon><!--container--><span class=\"task-name\">Merge Sort</span><!--container--><!--container--><span class=\"text-secondary\">artemisApp.editor.testStatusLabels.noTests</span><!--container--></div></div> \nImplement the method.</li>\n</ol>",


coderabbitai · 2024-09-06T20:34:50Z

Walkthrough

The changes involve modifications to the ProgrammingExerciseInstructionComponent and the problemStatement.json file. The component now generates unique task identifiers by including the exercise ID, preventing conflicts when multiple exercises are displayed. Additionally, the problem statements for sorting algorithms have been updated to enhance visual feedback, including dynamic status indicators and improved HTML structure.

Changes

Files	Change Summary
`src/main/webapp/app/exercises/programming/shared/instructions-render/programming-exercise-instruction.component.ts`, `src/test/javascript/spec/helpers/sample/problemStatement.json`	Updated task identifier generation to include exercise ID for uniqueness and enhanced HTML structure for problem statements with dynamic status indicators.

Assessment against linked issues

Objective	Addressed	Explanation
Show correct task (related to issue #9253)	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

undernagruzez

tested on ts2, students now see correct test cases

edkaya

Tested on TS2, works as expected.

az108

Code LGTM 👍

coolchock

tested on ts2, works as expected

)

SimonEntholzer added 2 commits September 6, 2024 22:12

fix tasks bug

058f048

fix client test

26c5dc4

github-actions bot assigned SimonEntholzer Sep 6, 2024

github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) labels Sep 6, 2024

SimonEntholzer changed the title ~~placeholder~~ Exam mode: Fix displaying incorrect task in exam exercise summary Sep 6, 2024

SimonEntholzer added small bugfix labels Sep 6, 2024

SimonEntholzer commented Sep 6, 2024

View reviewed changes

SimonEntholzer added the ready for review label Sep 6, 2024

SimonEntholzer marked this pull request as ready for review September 6, 2024 20:34

SimonEntholzer requested a review from a team as a code owner September 6, 2024 20:34

SimonEntholzer assigned eceeeren, JohannesWt, undernagruzez, BBesrour and Jan-Thurner and unassigned eceeeren, JohannesWt, undernagruzez, BBesrour and Jan-Thurner Sep 6, 2024

SimonEntholzer requested review from eceeeren, iyannsch, undernagruzez, asliayk, BBesrour and b-fein September 6, 2024 20:37

Merge branch 'develop' into chore/bugfix/fix-incorrect-task-bug

0753f37

undernagruzez added the deploy:artemis-test2 label Sep 8, 2024

undernagruzez temporarily deployed to artemis-test2.artemis.cit.tum.de September 8, 2024 14:47 — with GitHub Actions Inactive

github-actions bot added lock:artemis-test2 and removed deploy:artemis-test2 labels Sep 8, 2024

undernagruzez removed the lock:artemis-test2 label Sep 8, 2024

undernagruzez approved these changes Sep 8, 2024

View reviewed changes

edkaya approved these changes Sep 8, 2024

View reviewed changes

az108 approved these changes Sep 8, 2024

View reviewed changes

coolchock approved these changes Sep 8, 2024

View reviewed changes

Merge branch 'develop' into chore/bugfix/fix-incorrect-task-bug

229fb27

SimonEntholzer added the ready to merge label Sep 8, 2024

krusche added this to the 7.5.2 milestone Sep 9, 2024

krusche merged commit 9b517bc into develop Sep 9, 2024
33 of 45 checks passed

krusche deleted the chore/bugfix/fix-incorrect-task-bug branch September 9, 2024 21:05

This was referenced Sep 20, 2024

Programming exercises: Add Rust and JavaScript to plagiarism detection #9344

Merged

Development: Upgrade markdown library to markdown-it #9354

Open

JohannesWt pushed a commit that referenced this pull request Sep 23, 2024

Exam mode: Fix displaying incorrect task in exam summary exercise (#9294

7bf4507

)

This was referenced Sep 29, 2024

Development: Fix flaky e2e tests #9326

Merged

Text exercises: Replace feedback modal with inline feedback view #9395

Open

Programming exercises: Improve preliminary AI feedback #9324

Merged

This was referenced Oct 11, 2024

Development: Fix wrong result subscription for exam exercises #9453

Merged

Development: Fix exam assessment e2e tests failing #9462

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Exam mode`: Fix displaying incorrect task in exam summary exercise #9294

`Exam mode`: Fix displaying incorrect task in exam summary exercise #9294

SimonEntholzer commented Sep 6, 2024 •

edited

Loading

SimonEntholzer Sep 6, 2024 •

edited

Loading

SimonEntholzer Sep 6, 2024

coderabbitai bot commented Sep 6, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

undernagruzez left a comment

edkaya left a comment

az108 left a comment

coolchock left a comment

Exam mode: Fix displaying incorrect task in exam summary exercise #9294

Exam mode: Fix displaying incorrect task in exam summary exercise #9294

Conversation

SimonEntholzer commented Sep 6, 2024 • edited Loading

Checklist

General

Client

Motivation and Context

Description

Steps for Testing (Exam Mode Testing)

Testserver States

Review Progress

Code Review

Test / Exam Mode Test

Test Coverage

Screenshots

Summary by CodeRabbit

SimonEntholzer Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

SimonEntholzer Sep 6, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Sep 6, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

undernagruzez left a comment

Choose a reason for hiding this comment

edkaya left a comment

Choose a reason for hiding this comment

az108 left a comment

Choose a reason for hiding this comment

coolchock left a comment

Choose a reason for hiding this comment

`Exam mode`: Fix displaying incorrect task in exam summary exercise #9294

`Exam mode`: Fix displaying incorrect task in exam summary exercise #9294

SimonEntholzer commented Sep 6, 2024 •

edited

Loading

SimonEntholzer Sep 6, 2024 •

edited

Loading

coderabbitai bot commented Sep 6, 2024 •

edited

Loading