Text Exercises: Replace feedback modal with inline feedback view

[EneaGore]

Deploy only to TS1

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  - [ ] I strictly followed the principle of data economy for all database calls.
• I strictly followed the server coding and design guidelines.
• I added multiple integration tests (Spring) related to the features (with a high test coverage).
  - [ ] I added pre-authorization annotations according to the [guidelines](https://docs.artemis.cit.tum.de/dev/guidelines/server/#rest-endpoint-best-practices-for-authorization) and checked the course groups for all new REST Calls (security).
• I documented the Java code using JavaDoc style.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
• I strictly followed the principle of data economy for all client-server REST calls.
• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
• I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
• I documented the TypeScript code using JSDoc style.
• I added multiple screenshots/screencasts of my UI changes.
• I translated all newly inserted strings into English and German.

Motivation and Context

The previous PR in Athena Feedback for Text Exercises added the option to enable preliminary AI Feedback for students. This PR improves the way the feedback is viewed by adding a new route. Enhanced error handling, integration tests and some minor bug fixes are also included.

Description

Create new route to view the (preliminary) results inline on the text submission. Add the timeline to that view and make results not show the modal but use that route for text exercises.

Steps for Testing

Prerequisites:

• 1 Student
• 1 Text Exercise

1. Open a text exercise with athena feedback requests avilable
2. Request feedback from inside the editor and from the overview
3. Click on results and check that the correct submission is shown
4. Assessment should continue working as usual

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Performance Tests

• Test 1
• Test 2

Test Coverage

✅ ❌

Class/File	Line Coverage	Confirmation (assert/expect)
header-participation-page.component.ts	100%
exercise-scores.component.ts	95.59%
feedback.component.ts	95%
rating.component.ts	91.66%
result.component.ts	88.81%
result.service.ts	90.83%
result.utils.ts	89.18%
text-editor.component.ts	82.12%
text-editor.route.ts	100%
course-exercise-details.component.ts	88.37%
exercise-details-student-actions.component.ts	86.18%

Screenshots

Flow

H01E01.Coupling.and.Cohesion.WS24._.Test.Course.Enea.Gore.-.Google.Chrome.2024-09-14.06-37-35.mp4

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced functionality for retrieving non-Athena results in submissions, ensuring only valid results are returned.
  • Streamlined feedback generation process with detailed tracking of text segments and support for early feedback requests.
  • Implemented a new method for students to request automatic non-graded feedback.
  • Enhanced user interface for text exercises with improved button visibility and history viewing options.
  • Updated labels and tooltips for feedback request features to clarify context.

• Bug Fixes

  • Improved error handling during feedback generation to provide clearer user feedback.
  • Enhanced filtering logic for displaying successful submission results based on exam mode.

• Documentation

  • Updated localization files to include new keys for improved user interaction.

• Tests

  • Expanded test coverage for feedback suggestion toggling and submission handling scenarios.
  • Added new tests for various submission conditions and feedback request validations.