Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Exercises: Replace feedback modal with inline feedback view #9310

Closed
wants to merge 67 commits into from
Closed

Text Exercises: Replace feedback modal with inline feedback view #9310

wants to merge 67 commits into from

Commits on Sep 12, 2024

  1. Add new router link to pick submission, improve error handling and ui… 

    …, add text blocks
    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cd72413 View commit details
    Browse the repository at this point in the history

  2. minor fixes

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    10dd7a4 View commit details
    Browse the repository at this point in the history

  3. revert result history to basic old way and fix some tests

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    31bac76 View commit details
    Browse the repository at this point in the history

  4. remove no longer used history results scrollable option

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2f0e6ad View commit details
    Browse the repository at this point in the history

  5. fix cannot find getAll in test

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4183099 View commit details
    Browse the repository at this point in the history

  6. details

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7a949e9 View commit details
    Browse the repository at this point in the history

  7. ngtooltip -> tooltip

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2338dcd View commit details
    Browse the repository at this point in the history

  8. ngtooltip -> tooltip

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ee18bbd View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. clean up code and more fixed tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    82c5491 View commit details
    Browse the repository at this point in the history

  2. mock getAll function in tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cef96ed View commit details
    Browse the repository at this point in the history

  3. more tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a9c3e68 View commit details
    Browse the repository at this point in the history

  4. more tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    629d964 View commit details
    Browse the repository at this point in the history

  5. remove unused imports

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    53bc43f View commit details
    Browse the repository at this point in the history

  6. reduce codacy complexity

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a641a7c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @EneaGore
    EneaGore authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    136928a View commit details
    Browse the repository at this point in the history

  8. more tests, cleaner timeline

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8b98e0f View commit details
    Browse the repository at this point in the history

  9. last is possibly undefined

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bec70f4 View commit details
    Browse the repository at this point in the history

  10. improve coverage further

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    eb7549d View commit details
    Browse the repository at this point in the history

  11. more result component tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9f581d9 View commit details
    Browse the repository at this point in the history

  12. fix is possibly undefined in tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6bf027f View commit details
    Browse the repository at this point in the history

  13. and another one (tests)

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e5fd0ba View commit details
    Browse the repository at this point in the history

  14. even more tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8e3828a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. add translations and make submit add the submission to the participation

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    f0a0192 View commit details
    Browse the repository at this point in the history

  2. handle possibly undefined submissions array

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    baa0c0c View commit details
    Browse the repository at this point in the history

  3. revert passing results on submit

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    9961e30 View commit details
    Browse the repository at this point in the history

  4. keep results but no need to push submission, make smoother result com… 

    …ponent
    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    6a449eb View commit details
    Browse the repository at this point in the history

  5. fix test

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b5082ac View commit details
    Browse the repository at this point in the history

  6. unreferenced feedback exists too

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    3e10d01 View commit details
    Browse the repository at this point in the history

  7. assessment view exclude exam mode

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    ed965a8 View commit details
    Browse the repository at this point in the history

  8. and not or

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    4cdaf53 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @EneaGore
    EneaGore authored Sep 14, 2024
    Configuration menu
    Copy the full SHA
    18024f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. only show ai feedback button if it is enabled

    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    43df5cb View commit details
    Browse the repository at this point in the history

  2. improve translations and labels for feedback option

    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    38c0592 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/text-exercises/preliminary-feedback-view' of ht… 

    …tps://github.com/ls1intum/Artemis into feature/text-exercises/preliminary-feedback-view
    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    9ed844e View commit details
    Browse the repository at this point in the history

  4. show athena results even before the assessment due date

    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    246e25c View commit details
    Browse the repository at this point in the history

  5. add preliminary tag, and default to latest submission if given submis… 

    …sionId doesnt exist
    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    ecfd8e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. allow feedback requests if date is not set

    = Enea_Gore committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b518281 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. address feedback on PR, hide ai button after deadline, show timeline … 

    …only if length > 1, remove unused code. fix tests
    = Enea_Gore committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    81f885d View commit details
    Browse the repository at this point in the history

  2. dont send tutor result before assessment due date

    = Enea_Gore committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    312cc5a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @SimonEntholzer
    SimonEntholzer authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8aeb55e View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @FelixTJDietrich
    FelixTJDietrich authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0817502 View commit details
    Browse the repository at this point in the history

  2. fix result ratings and typos

    = Enea_Gore committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3beb2db View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/text-exercises/preliminary-feedback-view' of ht… 

    …tps://github.com/ls1intum/Artemis into feature/text-exercises/preliminary-feedback-view
    = Enea_Gore committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4deae4e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @EneaGore
    EneaGore authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2a12293 View commit details
    Browse the repository at this point in the history

  5. add new tests for rating component and text exercise resource with at… 

    …hena
    = Enea_Gore committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2ba858b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. branch coverage

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ca3fa04 View commit details
    Browse the repository at this point in the history

  2. no left side optional chaining

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cc5a0d8 View commit details
    Browse the repository at this point in the history

  3. add tests for html elements in text editor

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1a70ef6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @EneaGore
    EneaGore authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a490cfe View commit details
    Browse the repository at this point in the history

  5. revert changes to text feedback tests

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e5bed25 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feature/text-exercises/preliminary-feedback-view' of ht… 

    …tps://github.com/ls1intum/Artemis into feature/text-exercises/preliminary-feedback-view
    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2cd13dc View commit details
    Browse the repository at this point in the history

  7. test more branches

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    aa9e64e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @FelixTJDietrich
    FelixTJDietrich authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b55ff4d View commit details
    Browse the repository at this point in the history

  9. copmonent -> comp

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b4dc5fb View commit details
    Browse the repository at this point in the history

  10. fix test

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    19693da View commit details
    Browse the repository at this point in the history

  11. Merge branch 'feature/text-exercises/preliminary-feedback-view' of ht… 

    …tps://github.com/ls1intum/Artemis into feature/text-exercises/preliminary-feedback-view
    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0f067a7 View commit details
    Browse the repository at this point in the history

  12. fix issue where athena result needs to be deleted on submit causing i… 

    …nternal server error
    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fc48fec View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. add translations for preconditions not met server side

    = Enea_Gore committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    81c9355 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @EneaGore
    EneaGore authored Sep 21, 2024
    Configuration menu
    Copy the full SHA
    ee18df7 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @EneaGore
    EneaGore authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9748390 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @FelixTJDietrich
    FelixTJDietrich authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3906d8f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. resolve conflicts

    = Enea_Gore committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    396ed6a View commit details
    Browse the repository at this point in the history

  2. more conflict resolve

    = Enea_Gore committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2317fb6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    = Enea_Gore committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b7d8908 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feature/text-exercises/preliminary-feedba… 

    …ck-view
    @EneaGore
    EneaGore authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a612795 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/text-exercises/preliminary-feedback-view' of ht… 

    …tps://github.com/ls1intum/Artemis into feature/text-exercises/preliminary-feedback-view
    = Enea_Gore committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ef36e39 View commit details
    Browse the repository at this point in the history

  6. fix style

    = Enea_Gore committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2ec239d View commit details
    Browse the repository at this point in the history