-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iris
: Enable Iris for exercises based on their categories
#9461
Open
Hialus
wants to merge
3
commits into
develop
Choose a base branch
from
feature/iris/enable-by-categories
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+475
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y of the exercise
github-actions
bot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
client
Pull requests that update TypeScript code. (Added Automatically!)
database
Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment.
exercise
Pull requests that affect the corresponding module
iris
Pull requests that affect the corresponding module
programming
Pull requests that affect the corresponding module
text
Pull requests that affect the corresponding module
labels
Oct 13, 2024
This comment was marked as spam.
This comment was marked as spam.
JohannesStoehr
requested changes
Oct 14, 2024
src/main/java/de/tum/cit/aet/artemis/iris/dto/IrisCombinedChatSubSettingsDTO.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/cit/aet/artemis/iris/service/settings/IrisSettingsService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/cit/aet/artemis/iris/service/settings/IrisSettingsService.java
Show resolved
Hide resolved
src/main/java/de/tum/cit/aet/artemis/iris/service/settings/IrisSettingsService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/cit/aet/artemis/iris/service/settings/IrisSettingsService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/cit/aet/artemis/programming/repository/ProgrammingExerciseRepository.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
HawKhiem
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
October 16, 2024 18:00
— with
GitHub Actions
Inactive
HawKhiem
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Pull requests that update TypeScript code. (Added Automatically!)
database
Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment.
exercise
Pull requests that affect the corresponding module
iris
Pull requests that affect the corresponding module
programming
Pull requests that affect the corresponding module
ready for review
server
Pull requests that update Java code. (Added Automatically!)
tests
text
Pull requests that affect the corresponding module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
Changes affecting Programming Exercises
High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.Not applicable, due to instructor only feature
Motivation and Context
Currently, instructors have to enable Iris for every individual exercise, which is annoying and easy to miss for one exercise.
A better option would be to enable Iris automatically for exercises based on some criteria or to switch between opt-in and opt-out for exercises.
After talking with @bassner and @krusche, we decided that the way to go is to enable Iris automatically based on the categories of exercises.
Description
Steps for Testing
Prerequisites:
a. If the exercise has a category that is included in the course Iris settings, Iris is enabled
b. If the exercise has no category that is in the course Iris settings, Iris is disabled (unless manually enabled)
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
even for very large courses with more than 2000 students.even for very large courses with more than 2000 students.Not applicable, due to instructor only feature
Code Review
Manual Tests
Test Coverage
Will be added, once the server tests on GitHub run through 🙃
Screenshots
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
Tests
@coderabbitai ignore (Because of spam)