Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43182: Prompt Processing GitHub Actions don't account for test-only PRs #134

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

kfindeisen
Copy link
Member

@kfindeisen kfindeisen commented Mar 6, 2024

This PR modifies the Prompt Processing build actions to trigger when the unit tests are updated, to confirm that the new tests pass. It also places the "Release CI" workflow under the same restrictions as "Build and test service", so that it does not trigger on non-code changes.

Unfortunately, since both workflows trigger on changes to the workflow, it's not possible to test these changes on this PR.

While we don't necessarily want to deploy a service in this case, it's
important to verify that the tests are functional.
This workflow now runs on the same PRs as 'Build and test service',
reducing confusion and avoiding gratuitous builds for doc or
repository-maintenance changes.
@kfindeisen kfindeisen requested a review from dspeck1 March 6, 2024 21:29
Copy link
Collaborator

@dspeck1 dspeck1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfindeisen kfindeisen merged commit 1a1cb21 into main Mar 6, 2024
7 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-43182 branch March 6, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants