Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43182: Prompt Processing GitHub Actions don't account for test-only PRs #134

Merged
merged 3 commits into from
Mar 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ jobs:
STACK_TAG: ${{ inputs.stackTag }}
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/build-service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ on:
- '.github/workflows/build-service.yml'
- 'pipelines/**'
- 'python/activator/**'
- 'tests/**'
- 'Dockerfile'
pull_request:
paths:
- '.github/workflows/build-service.yml'
- 'pipelines/**'
- 'python/activator/**'
- 'tests/**'
- 'Dockerfile'
workflow_dispatch:

Expand Down Expand Up @@ -49,11 +51,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Fix permissions
run: chmod -R a+rwX $GITHUB_WORKSPACE
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down Expand Up @@ -85,9 +87,9 @@ jobs:
BASE_TAG: ${{ matrix.baseTag }}
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/ci-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,14 @@ name: Release CI
- "u/**"
tags:
- "*"
pull_request: {}
pull_request:
# Matches build-service.yml
paths:
- '.github/workflows/ci-release.yaml'
- 'pipelines/**'
- 'python/activator/**'
- 'tests/**'
- 'Dockerfile'

env:
# Base tag to run tests against.
Expand All @@ -28,13 +35,13 @@ jobs:
|| startsWith(github.head_ref, 'tickets/')

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Fix permissions
run: chmod -R a+rwX $GITHUB_WORKSPACE

- name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down
Loading