Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-47333: Logger.exception() missing 1 required positional argument #214

Merged
merged 1 commit into from
Nov 5, 2024
Merged

DM-47333: Logger.exception() missing 1 required positional argument #214

merged 1 commit into from
Nov 5, 2024

Conversation

hsinfang
Copy link
Collaborator

@hsinfang hsinfang commented Nov 4, 2024

No description provided.

@hsinfang hsinfang mentioned this pull request Nov 4, 2024
Merged
kfindeisen
kfindeisen approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for putting up with my nit-picking! 🙂

@hsinfang
Copy link
Collaborator Author

hsinfang commented Nov 5, 2024

Many thanks for looking and catching the problem!

@hsinfang hsinfang merged commit dc7d981 into main Nov 5, 2024
5 checks passed
@hsinfang hsinfang deleted the tickets/DM-47333 branch November 5, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsinfang @kfindeisen