Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41664: Rename prompt_prototype package and containers #96

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

kfindeisen
Copy link
Member

This PR updates all code and docs from prompt_processing to prompt_prototype, and renames the containers from prompt-proto-* to prompt-*. The only remaining references to "proto" are those to prompt-proto-service, which will be renamed at a later date.

Very few files used the "prototype" name, because we're not following
the LSST namespace conventions.
These references are the minimum needed for the code to build and
deploy correctly.
These references are not essential for the code to work (most are in
docs), but avoid confusion over the status of Prompt Processing.
We're no longer using a single prompt-proto-service namespace, nor the
knative-serving namespace.
This rename only affects the containers; the services that use them
will still be called prompt-proto-service-* until a later issue.
Copy link
Collaborator

@hsinfang hsinfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfindeisen kfindeisen merged commit 38c2c75 into main Nov 14, 2023
5 of 6 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-41664 branch November 14, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants