Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34496: Remove already-deprecated fake-source insertion interfaces #804

Merged
merged 1 commit into from
Jun 29, 2023
Merged

DM-34496: Remove already-deprecated fake-source insertion interfaces #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions doc/lsst.pipe.tasks/tasks/lsst.pipe.tasks.fakes.BaseFakeSourcesTask.rst
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions python/lsst/pipe/tasks/calibrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
from lsst.meas.deblender import SourceDeblendTask
from lsst.utils.timer import timeMethod
from lsst.pipe.tasks.setPrimaryFlags import SetPrimaryFlagsTask
from .fakes import BaseFakeSourcesTask
from .photoCal import PhotoCalTask
from .computeExposureSummaryStats import ComputeExposureSummaryStatsTask

Expand Down Expand Up @@ -286,20 +285,6 @@ class CalibrateConfig(pipeBase.PipelineTaskConfig, pipelineConnections=Calibrate
target=CatalogCalculationTask,
doc="Subtask to run catalogCalculation plugins on catalog"
)
doInsertFakes = pexConfig.Field(
dtype=bool,
default=False,
doc="Run fake sources injection task",
deprecated=("doInsertFakes is no longer supported. This config will be removed after v24. "
"Please use ProcessCcdWithFakesTask instead.")
)
insertFakes = pexConfig.ConfigurableField(
target=BaseFakeSourcesTask,
doc="Injection of fake sources for testing purposes (must be "
"retargeted)",
deprecated=("insertFakes is no longer supported. This config will be removed after v24. "
"Please use ProcessCcdWithFakesTask instead.")
)
doComputeSummaryStats = pexConfig.Field(
dtype=bool,
default=True,
Expand Down
80 changes: 0 additions & 80 deletions python/lsst/pipe/tasks/fakes.py
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions python/lsst/pipe/tasks/multiBand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
SkyMapIdGeneratorConfig,
)
from lsst.meas.astrom import DirectMatchTask, denormalizeMatches
from lsst.pipe.tasks.fakes import BaseFakeSourcesTask
from lsst.pipe.tasks.setPrimaryFlags import SetPrimaryFlagsTask
from lsst.pipe.tasks.propagateSourceFlags import PropagateSourceFlagsTask
import lsst.afw.table as afwTable
Expand Down Expand Up @@ -109,15 +108,6 @@ class DetectCoaddSourcesConfig(PipelineTaskConfig, pipelineConnections=DetectCoa
scaleVariance = ConfigurableField(target=ScaleVarianceTask, doc="Variance rescaling")
detection = ConfigurableField(target=DynamicDetectionTask, doc="Source detection")
coaddName = Field(dtype=str, default="deep", doc="Name of coadd")
doInsertFakes = Field(dtype=bool, default=False,
doc="Run fake sources injection task",
deprecated=("doInsertFakes is no longer supported. This config will be removed "
"after v24."))
insertFakes = ConfigurableField(target=BaseFakeSourcesTask,
doc="Injection of fake sources for testing "
"purposes (must be retargeted)",
deprecated=("insertFakes is no longer supported. This config will "
"be removed after v24."))
hasFakes = Field(
dtype=bool,
default=False,
Expand Down