Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34496: Remove already-deprecated fake-source insertion interfaces #804

Merged
merged 1 commit into from
Jun 29, 2023
Merged

DM-34496: Remove already-deprecated fake-source insertion interfaces #804

merged 1 commit into from
Jun 29, 2023

Conversation

jtmccann
Copy link
Contributor

No description provided.

@leeskelvin
Copy link
Contributor

LGTM!

@leeskelvin leeskelvin self-requested a review June 29, 2023 21:51
@jtmccann jtmccann merged commit 2e59211 into main Jun 29, 2023
1 check passed
@jtmccann jtmccann deleted the tickets/DM-34496 branch June 29, 2023 21:52
leeskelvin
leeskelvin reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@leeskelvin leeskelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS - I was concerned that AP may still be using some of these tools, but on closer inspection, I think we're safe. So, in summary, this still LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeskelvin leeskelvin leeskelvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtmccann @leeskelvin