Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI coverage #200

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Fix CI coverage #200

merged 5 commits into from
Nov 23, 2023

Conversation

sphamba
Copy link
Collaborator

@sphamba sphamba commented Nov 23, 2023

Summary

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Inconclusive -- All modified content is filtered away. This is either due to excluded content in your CodeScene settings, or because the change set only contains renames.
View detailed results in CodeScene

@coveralls
Copy link
Collaborator

coveralls commented Nov 23, 2023

Coverage Status

coverage: 78.644% (-8.1%) from 86.707%
when pulling d58287a on EPFL-ENAC:fix-ci-coverage
into a3fe57e on ltelab:main.

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 327 lines in your changes are missing coverage. Please review.

Comparison is base (a72dadd) 86.69% compared to head (d58287a) 78.87%.
Report is 86 commits behind head on main.

Files Patch % Lines
disdrodb/l0/l0b_nc_processing.py 0.00% 138 Missing ⚠️
disdrodb/api/check_directories.py 84.51% 35 Missing ⚠️
disdrodb/data_transfer/zenodo.py 75.00% 26 Missing ⚠️
disdrodb/configs.py 58.62% 24 Missing ⚠️
disdrodb/l0/l0_processing.py 79.22% 16 Missing ⚠️
disdrodb/l0/template_tools.py 0.00% 16 Missing ⚠️
disdrodb/l0/check_configs.py 83.72% 14 Missing ⚠️
disdrodb/api/io.py 81.66% 11 Missing ⚠️
disdrodb/l0/standards.py 86.56% 9 Missing ⚠️
disdrodb/l0/routines.py 92.92% 8 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   86.69%   78.87%   -7.82%     
==========================================
  Files          51       48       -3     
  Lines        5162     3617    -1545     
==========================================
- Hits         4475     2853    -1622     
- Misses        687      764      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

@sphamba sphamba marked this pull request as ready for review November 23, 2023 13:39
@sphamba sphamba merged commit c9ab15a into ltelab:main Nov 23, 2023
11 of 13 checks passed
@sphamba sphamba deleted the fix-ci-coverage branch November 23, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants