Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lua 5.4 to test matrices #321

Closed
wants to merge 2 commits into from
Closed

Conversation

alerque
Copy link
Member

@alerque alerque commented Jul 21, 2020

No description provided.

@alerque alerque changed the title Add Lua 5.4 to Travis test matrix Add Lua 5.4 to test matrices Jul 21, 2020
@alerque
Copy link
Member Author

alerque commented Jul 21, 2020

I've opened an upstream report about luacheck, but at the same time I'm pretty sure that doesn't need to get run for every Lua version in the matrix, it only needs to be run once.

@alerque
Copy link
Member Author

alerque commented Jul 21, 2020

The error thrown by the test suite here does not seem to be the same as the one shown in #320. Apparently there is more to fix ... and I'm guessing the test runner order may be non-deterministic.

@mcepl Did you get past the rest of the test suite after patching that one issue?

@mcepl
Copy link

mcepl commented Jul 21, 2020

@mcepl Did you get past the rest of the test suite after patching that one issue?

I do believe so. See https://build.opensuse.org/package/show/devel:languages:lua/lua-penlight (click on the “succeed” links to see the build logs), or this build log (search for %check string to find the beginning of the testing phase).

@Tieske Tieske closed this in #323 Jul 28, 2020
@alerque alerque deleted the test-lua54 branch September 29, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants