-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pull_request_template.md #1157
Conversation
@resilience-jychp , what do you think? |
@ramonpetgrave64 may you can add :
May be you can refer to @achantavy Google Doc or add some precisions about auto cleanup (only Node with sub-resource link will be deleted) May be adding a link to analysis jobs can be helpful too. A bit out of scope but a detailed exemple of transform with n to n cardinality will be useful. This template will be helpful. |
This is very good documentation feedback, thank you. Regarding the pull request template, I think a long list like this would do better in the how to write an intel module guide instead of this checklist. I think we should keep a pull request template to roughly 5 items max. This is meant to remind a contributor of things they might have missed, not show them how to do everything. |
@achantavy @resilience-jychp Thanks. I've shortened it and mentioned the readme |
@ramonpetgrave64 may be you can add a reminder for "extra-index" in your checklist |
|
3382906
to
5143d30
Compare
Adds some guidance on how to edit/create intel modules