-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align LDOS vectors to a reference #574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marking this as ready for review now. Some comments:
|
I'll take a stab at it once I find the time. Feel free to merge before that, this can also go in separately. |
Thanks for the work @timcallow , looks good to me. I will merge this for now and open an issue to track the OpenPMD progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns a set of LDOS vectors to a reference. Optionally, the LDOS vectors can also be truncated from the left and right. This makes learning easier when the LDOS vectors become non-zero at different points, and/or are truncated (due to finite number of bands) at different points, such as when different mass densities are considered.
Remaining tasks need to be done or at least discussed before merging:
Extend to snapshots stored as openPMDInclude additional information files