-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for v4 #3611
Update docs for v4 #3611
Conversation
This is a non breaking change that prevents the method needing `this` or documenting `this.$container`
a216fe7
to
3760fda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of work! I'm all in to merge this and fixing / rewording afterward, but even until this, it already looks amazing!
docs/view.lifecycle.md
Outdated
#### Adding unmanaged children | ||
|
||
Unlike managed children there may be cases where you want to insert views to the results of the `CollectionView` after the | ||
`collecton` changes, or after sorting and/or filtering. In these cases the solution might depend slightly on the features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: collection
changes,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
I can help with that. See #3447. Must settle on a format |
3760fda
to
d7772bf
Compare
@marionettejs/marionette-core as promised I've finally finished doc modifications. I am well aware that this is a huge PR and likely unmanageable as far as reviewing. My suggestion would be to skim it, and unless there's anything big we can make changes in subsequent PRs as we alpha/beta v4.
There was one tiny functional code change explained on the commit: d4330ec
The other changes to src files are changes that are either code comment updates or URL updates for errors.
This work does a few things:
What this doesn't do:
Once this gets in I'll make an alpha branch 🎉
If you want to visually click through: https://github.com/paulfalgout/backbone.marionette/blob/doc-updates-views/docs/basics.md