Skip to content

feat: model special resource requests too #634

feat: model special resource requests too

feat: model special resource requests too #634

Triggered via pull request July 18, 2024 16:58
@preyasshahpreyasshah
synchronize #512
ps/hacks
Status Success
Total duration 26s
Artifacts

clippy.yml

on: pull_request
clippy_check
19s
clippy_check
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
clippy_check
The following actions uses Node.js version which is deprecated and will be forced to run on node20: 10XGenomics/clippy-check@main. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead: martian/src/metadata.rs#L388
warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead --> martian/src/metadata.rs:388:9 | 388 | insta::assert_display_snapshot!(e.unwrap_err()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
variables can be used directly in the `format!` string: martian/src/mro.rs#L36
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:36:17 | 36 | / assert!( 37 | | width >= min_width, 38 | | "Need a minimum width of {}. Found {}", 39 | | min_width, 40 | | width 41 | | ); | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: requested on the command line with `-W clippy::uninlined-format-args`
variables can be used directly in the `format!` string: martian/src/mro.rs#L113
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:113:13 | 113 | writeln!(f, " {},", formatted_line)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 113 - writeln!(f, " {},", formatted_line)?; 113 + writeln!(f, " {formatted_line},")?; |
variables can be used directly in the `format!` string: martian/src/mro.rs#L526
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:526:13 | 526 | / assert!( 527 | | self.name != token, 528 | | "Martian token {} cannot be used as field name", 529 | | token 530 | | ); | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: martian/src/mro.rs#L926
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:926:13 | 926 | / write!( 927 | | f, 928 | | "{params:<ty_width$}", 929 | | params = chunk_in_out, 930 | | ty_width = ty_width 931 | | )?; | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: martian-derive/src/lib.rs#L327
warning: variables can be used directly in the `format!` string --> martian-derive/src/lib.rs:327:9 | 327 | / format!( 328 | | "{}. You are trying to use it on {} trait implementation.", 329 | | ATTR_NOT_ON_TRAIT_IMPL_ERROR, last_ident 330 | | ), | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: requested on the command line with `-W clippy::uninlined-format-args`
variables can be used directly in the `format!` string: martian-derive/src/lib.rs#L555
warning: variables can be used directly in the `format!` string --> martian-derive/src/lib.rs:555:17 | 555 | / format!( 556 | | "Field name {} is not allowed here since it is a martian keyword", 557 | | name 558 | | ), | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args