Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #2737

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

joanna-konopacka
Copy link

No description provided.

Copy link

@vlasiuksasha vlasiuksasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the comments

break;

default:
return "Error: Type Unknown";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 'default' case of your switch statement, you are returning a string. This will end the execution of the function, even if there are more valid actions in the 'actions' array. Instead, consider logging the error or ignoring the action with an invalid type.

function transformState(state, actions) {
// write code here
for (const action of actions) {
const { type, extraData, keysToRemove } = action;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The destructuring of 'action' assumes that every action object has 'extraData' and 'keysToRemove' properties. This can potentially cause 'undefined' errors if these properties are absent. Consider destructuring these properties inside their respective case blocks.

}
break;

case "clear":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, there is a small issue with the "clear" case. When you want to clear all properties from the state object, using a for...in loop may not work as expected. Instead, you should use Object.keys to get an array of keys and then delete each key.

Copy link

@Ivan-Shvorak Ivan-Shvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants