Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #2737

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

solution #2737

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c3404b7
solution
joanna-konopacka Oct 30, 2023
9134591
solution
joanna-konopacka Oct 30, 2023
8ad514f
solution
joanna-konopacka Oct 30, 2023
d76f5a8
solution
joanna-konopacka Oct 30, 2023
3aa537e
solution
joanna-konopacka Oct 30, 2023
5249124
solution
joanna-konopacka Nov 1, 2023
6d026f9
solution
joanna-konopacka Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions src/transformState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,30 @@
'use strict';
"use strict";

/**
* @param {Object} state
* @param {Object[]} actions
*/
function transformState(state, actions) {
// write code here
for (const action of actions) {
const { type, extraData, keysToRemove } = action;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The destructuring of 'action' assumes that every action object has 'extraData' and 'keysToRemove' properties. This can potentially cause 'undefined' errors if these properties are absent. Consider destructuring these properties inside their respective case blocks.

switch (type) {
case "addProperties":
Object.assign(state, extraData);
break;

case "removeProperties":
for (const key of keysToRemove) {
delete state[key];
}
break;

case "clear":
for (const key in state) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, there is a small issue with the "clear" case. When you want to clear all properties from the state object, using a for...in loop may not work as expected. Instead, you should use Object.keys to get an array of keys and then delete each key.

delete state[key];
}
break;

default:
return "Error: Type Unknown";
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 'default' case of your switch statement, you are returning a string. This will end the execution of the function, even if there are more valid actions in the 'actions' array. Instead, consider logging the error or ignoring the action with an invalid type.

}
}

module.exports = transformState;
Loading