Add new Method #1060
Open
Add new Method #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Jul 1, 2024
| @@ -13,7 +13,15 @@ public String getEmail() { | |||
| return email; | |||
| } | |||
|
|
|||
| public void setEmail(String email) { | |||
| public String getPassword() { | ||
| return password; | ||
| } | ||
|
|
||
| public void setPassword(String password) { |
| if (user == null) { | ||
| return false; | ||
| } | ||
| return user.getPassword().equals(password); |
There was a problem hiding this comment.
Suggested change
| return user.getPassword().equals(password); | |
| return user != null && user.getPassword().equals(password); |
| public boolean login(String email, String password) { | ||
| return false; | ||
| User user = userService.findByEmail(email); | ||
| if (user == null) { |
There was a problem hiding this comment.
Suggested change
| if (user == null) { |
There was a problem hiding this comment.
you make this validation on 29th line, so this check is redundant
MentorMateAcademy
suggested changes
Jul 9, 2024
| public boolean login(String email, String password) { | ||
| return false; | ||
| User user = userService.findByEmail(email); | ||
| if (user == null) { |
Comment on lines
25
to
27
| if (user == null) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (user == null) { | |
| return false; | |
| } |
MAMentorFX
suggested changes
Jul 10, 2024
| public boolean login(String email, String password) { | ||
| return false; | ||
| User user = userService.findByEmail(email); | ||
| if (user == null) { |
| public boolean login(String email, String password) { | ||
| return false; | ||
| User user = userService.findByEmail(email); | ||
| if (user == null) { |
There was a problem hiding this comment.
you make this validation on 29th line, so this check is redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.