-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Method #1060
base: master
Are you sure you want to change the base?
Add new Method #1060
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
package mate.academy; | ||
|
||
import mate.academy.service.AuthenticationService; | ||
import mate.academy.service.UserService; | ||
|
||
public class Main { | ||
private static final AuthenticationService authenticationService = new AuthenticationService(); | ||
private static final AuthenticationService authenticationService = | ||
new AuthenticationService(new UserService()); | ||
|
||
public static void main(String[] args) { | ||
test("[email protected]", "1234", true); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,15 @@ public String getEmail() { | |
return email; | ||
} | ||
|
||
public void setEmail(String email) { | ||
this.email = email; | ||
} | ||
|
||
public String getPassword() { | ||
return password; | ||
} | ||
|
||
public void setPassword(String password) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove |
||
this.password = password; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -1,16 +1,29 @@ | ||||||||
package mate.academy.service; | ||||||||
|
||||||||
import mate.academy.model.User; | ||||||||
|
||||||||
public class AuthenticationService { | ||||||||
private final UserService userService; | ||||||||
|
||||||||
public AuthenticationService(UserService userService) { | ||||||||
this.userService = userService; | ||||||||
} | ||||||||
/** | ||||||||
* Imagine that some user wants to login to your site. | ||||||||
* You should check if user credentials (login and password) are valid or not. | ||||||||
* All users are stored in <code>UserService</code> class. | ||||||||
* @param email - user's email | ||||||||
* | ||||||||
* @param email - user's email | ||||||||
* @param password - user's password | ||||||||
* @return true if user by email exists and passed password is equal to user's password. | ||||||||
* Return false in any other cases. | ||||||||
*/ | ||||||||
|
||||||||
public boolean login(String email, String password) { | ||||||||
return false; | ||||||||
User user = userService.findByEmail(email); | ||||||||
if (user == null) { | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not fixed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not fixed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you make this validation on 29th line, so this check is redundant |
||||||||
return false; | ||||||||
} | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
return user.getPassword().equals(password); | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
} | ||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove