Authentification service branch #1067

xli1iax · 2024-07-20T13:49:26Z

No description provided.

MentorMateAcademy · 2024-07-20T17:19:10Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -11,6 +13,13 @@ public class AuthenticationService {
     * Return false in any other cases.
     */
    public boolean login(String email, String password) {
+        UserService user = new UserService();


Suggested change

UserService user = new UserService();

UserService userService = new UserService();

MentorMateAcademy · 2024-07-20T17:19:33Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -11,6 +13,13 @@ public class AuthenticationService {
     * Return false in any other cases.
     */
    public boolean login(String email, String password) {
+        UserService user = new UserService();


create object outside of method

MentorMateAcademy · 2024-07-20T17:19:54Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -11,6 +13,13 @@ public class AuthenticationService {
     * Return false in any other cases.
     */
    public boolean login(String email, String password) {
+        UserService user = new UserService();
+        User found = user.findByEmail(email);


Suggested change

User found = user.findByEmail(email);

User user = userService.findByEmail(email);

MentorMateAcademy · 2024-07-20T17:20:17Z

src/main/java/mate/academy/service/AuthenticationService.java

+        if (found != null) {
+            if (found.getPassword().equals(password)) {
+                return true;
+            }
+        }
        return false;


simplify it using one return

MentorMateAcademy · 2024-07-20T17:20:30Z

src/main/java/mate/academy/service/UserService.java

@@ -15,6 +15,11 @@ public class UserService {
     * Return <code>null</code> if there is no suitable user
     */
    public User findByEmail(String email) {
+        for (User i: users) {


Suggested change

for (User i: users) {

for (User user : users) {

not fixed, rename variable

Elena-Bruyako · 2024-07-21T08:23:33Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -11,6 +13,9 @@ public class AuthenticationService {
     * Return false in any other cases.
     */
    public boolean login(String email, String password) {
-        return false;
+        UserService userService = new UserService();
+        User userToCheck = userService.findByEmail(email);


Suggested change

User userToCheck = userService.findByEmail(email);

User user = userService.findByEmail(email);

Elena-Bruyako · 2024-07-21T08:23:46Z

src/main/java/mate/academy/service/UserService.java

@@ -15,6 +15,11 @@ public class UserService {
     * Return <code>null</code> if there is no suitable user
     */
    public User findByEmail(String email) {
+        for (User i: users) {


not fixed, rename variable

…ide the method

Elena-Bruyako · 2024-07-21T19:35:32Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -10,7 +12,15 @@ public class AuthenticationService {
     * @return true if user by email exists and passed password is equal to user's password.
     * Return false in any other cases.
     */
+    private UserService userService = new UserService();


Suggested change

private UserService userService = new UserService();

private final UserService userService = new UserService();

Elena-Bruyako · 2024-07-21T19:35:40Z

src/main/java/mate/academy/service/AuthenticationService.java

+    public UserService getUserService() {
+        return userService;
+    }


Suggested change

public UserService getUserService() {

return userService;

}

Elena-Bruyako · 2024-07-21T19:35:53Z

src/main/java/mate/academy/service/AuthenticationService.java

    public boolean login(String email, String password) {
-        return false;
+        User userToCheck = getUserService().findByEmail(email);


Suggested change

User userToCheck = getUserService().findByEmail(email);

User user =userService.findByEmail(email);

…l UserService

Elena-Bruyako · 2024-07-22T13:35:55Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -10,7 +12,17 @@ public class AuthenticationService {
     * @return true if user by email exists and passed password is equal to user's password.
     * Return false in any other cases.
     */
+    private final UserService userService = new UserService();
+
+    public UserService getUserService() {


Why do you need this get method?

to get the variable, Intellij IDEA indicated that it is better to make UserService object private and to get it I created the get method

Not all advice from Idea should be implemented

remove this get method

Elena-Bruyako · 2024-07-22T16:49:43Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -10,7 +12,17 @@ public class AuthenticationService {
     * @return true if user by email exists and passed password is equal to user's password.
     * Return false in any other cases.
     */
+    private final UserService userService = new UserService();
+
+    public UserService getUserService() {


remove this get method

Elena-Bruyako · 2024-07-22T16:49:52Z

src/main/java/mate/academy/service/AuthenticationService.java

    public boolean login(String email, String password) {
-        return false;
+        User user = getUserService().findByEmail(email);


Suggested change

User user = getUserService().findByEmail(email);

User user = userService.findByEmail(email);

Elena-Bruyako · 2024-07-22T16:51:15Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -10,7 +12,17 @@ public class AuthenticationService {
     * @return true if user by email exists and passed password is equal to user's password.
     * Return false in any other cases.
     */
+    private final UserService userService = new UserService();


Your code should look like

Suggested change

private final UserService userService = new UserService();

private final UserService userService = new UserService();

public boolean login(String email, String password) {

User user = userService.findByEmail(email);

return user != null && user.getPassword().equals(password);

}

xli1iax added 2 commits July 20, 2024 16:46

created login method

1c10ef6

created findByEmail method

eb0dac0

MentorMateAcademy suggested changes Jul 20, 2024

View reviewed changes

corrected naming and method

7deefef

xli1iax requested a review from MentorMateAcademy July 20, 2024 22:45

Elena-Bruyako suggested changes Jul 21, 2024

View reviewed changes

xli1iax added 2 commits July 21, 2024 22:16

added setter and made the userService variable private and moved outs…

8f15ec6

…ide the method

renamed name of elements in the loop

b37e6a5

xli1iax requested a review from Elena-Bruyako July 21, 2024 19:18

Elena-Bruyako suggested changes Jul 21, 2024

View reviewed changes

renamed User object and corrected private UserService to private fina…

7fdca45

…l UserService

xli1iax requested a review from Elena-Bruyako July 21, 2024 20:53

corrected getter

9c4cf1e

Elena-Bruyako suggested changes Jul 22, 2024

View reviewed changes

xli1iax requested a review from Elena-Bruyako July 22, 2024 16:01

Elena-Bruyako suggested changes Jul 22, 2024

View reviewed changes

removed get method

41ba5ec

xli1iax requested a review from Elena-Bruyako July 22, 2024 16:56

Elena-Bruyako approved these changes Jul 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Authentification service branch #1067

Authentification service branch #1067

xli1iax commented Jul 20, 2024

MentorMateAcademy Jul 20, 2024

MentorMateAcademy Jul 20, 2024

MentorMateAcademy Jul 20, 2024

MentorMateAcademy Jul 20, 2024

MentorMateAcademy Jul 20, 2024

Elena-Bruyako Jul 21, 2024

Elena-Bruyako Jul 21, 2024

Elena-Bruyako Jul 21, 2024

Elena-Bruyako Jul 21, 2024

Elena-Bruyako Jul 21, 2024

Elena-Bruyako Jul 21, 2024

Elena-Bruyako Jul 22, 2024

xli1iax Jul 22, 2024 •

edited

Loading

Elena-Bruyako Jul 22, 2024

Elena-Bruyako Jul 22, 2024

Elena-Bruyako Jul 22, 2024

Elena-Bruyako Jul 22, 2024

Elena-Bruyako Jul 22, 2024

	UserService user = new UserService();
	UserService userService = new UserService();

	User found = user.findByEmail(email);
	User user = userService.findByEmail(email);

	User userToCheck = userService.findByEmail(email);
	User user = userService.findByEmail(email);

	private UserService userService = new UserService();
	private final UserService userService = new UserService();

	User userToCheck = getUserService().findByEmail(email);
	User user =userService.findByEmail(email);

	User user = getUserService().findByEmail(email);
	User user = userService.findByEmail(email);

Authentification service branch #1067

Are you sure you want to change the base?

Authentification service branch #1067

Conversation

xli1iax commented Jul 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xli1iax Jul 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xli1iax Jul 22, 2024 •

edited

Loading