-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentification service branch #1067
base: master
Are you sure you want to change the base?
Changes from 2 commits
1c10ef6
eb0dac0
7deefef
8f15ec6
b37e6a5
7fdca45
9c4cf1e
41ba5ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,7 @@ | ||||||
package mate.academy.service; | ||||||
|
||||||
import mate.academy.model.User; | ||||||
|
||||||
public class AuthenticationService { | ||||||
/** | ||||||
* Imagine that some user wants to login to your site. | ||||||
|
@@ -11,6 +13,13 @@ public class AuthenticationService { | |||||
* Return false in any other cases. | ||||||
*/ | ||||||
public boolean login(String email, String password) { | ||||||
UserService user = new UserService(); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. create object outside of method |
||||||
User found = user.findByEmail(email); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
if (found != null) { | ||||||
if (found.getPassword().equals(password)) { | ||||||
return true; | ||||||
} | ||||||
} | ||||||
return false; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. simplify it using one return |
||||||
} | ||||||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -15,6 +15,11 @@ public class UserService { | |||||
* Return <code>null</code> if there is no suitable user | ||||||
*/ | ||||||
public User findByEmail(String email) { | ||||||
for (User i: users) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not fixed, rename variable |
||||||
if (i.getEmail().equals(email)) { | ||||||
return i; | ||||||
} | ||||||
} | ||||||
return null; | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.