generated from mate-academy/jv-homework-template
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for bonus task, with new branch #1104
Open
Sasha1256
wants to merge
8
commits into
mate-academy:master
Choose a base branch
from
Sasha1256:bonus-task
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
809f9c4
for bonus task? with new branch
Sasha1256 c03d5b9
for bonus task? with new branch
Sasha1256 13c37dd
for bonus task? with new branch
Sasha1256 52a29ed
Can you see now?
Sasha1256 4473f53
Can you see now?
Sasha1256 2351174
I have already fixed it
Sasha1256 142095f
I hope it`s over
Sasha1256 5be4abf
I updated method "login"
Sasha1256 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,5 +1,7 @@ | ||||||||||||||||||||
package mate.academy.service; | ||||||||||||||||||||
|
||||||||||||||||||||
import mate.academy.model.User; | ||||||||||||||||||||
|
||||||||||||||||||||
public class AuthenticationService { | ||||||||||||||||||||
/** | ||||||||||||||||||||
* Imagine that some user wants to login to your site. | ||||||||||||||||||||
|
@@ -10,7 +12,16 @@ public class AuthenticationService { | |||||||||||||||||||
* @return true if user by email exists and passed password is equal to user's password. | ||||||||||||||||||||
* Return false in any other cases. | ||||||||||||||||||||
*/ | ||||||||||||||||||||
private UserService userService = new UserService(); | ||||||||||||||||||||
|
||||||||||||||||||||
public boolean login(String email, String password) { | ||||||||||||||||||||
return false; | ||||||||||||||||||||
boolean userExist = false; | ||||||||||||||||||||
User user = userService.findByEmail(email); | ||||||||||||||||||||
if (user != null) { | ||||||||||||||||||||
if (user.getPassword().equals(password)) { | ||||||||||||||||||||
userExist = true; | ||||||||||||||||||||
} | ||||||||||||||||||||
} | ||||||||||||||||||||
return userExist; | ||||||||||||||||||||
} | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.