-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #1277
base: master
Are you sure you want to change the base?
solution #1277
Conversation
if (dateEmploy[2] >= dateSalaryFrom[2] && dateEmploy[2] <= dateSalaryTo[2]) { | ||
if (dateEmploy[1] >= dateSalaryFrom[1] && dateEmploy[1] <= dateSalaryTo[1]) { | ||
return !(dateEmploy[1] == dateSalaryFrom[1] | ||
&& dateEmploy[0] < dateSalaryFrom[0]) | ||
&& !(dateEmploy[1] == dateSalaryTo[1] | ||
&& dateEmploy[0] > dateSalaryTo[0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use constants for such indexes.
It is easier to read date[INDEX_OF_DATE] instead of date[0] and so on
return dateInArrayInteger; | ||
} | ||
|
||
private boolean workingUpToDate(int[] dateEmploy, int[] dateSalaryFrom, int[] dateSalaryTo) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is dateEmploy
? Please try to write more meaningful names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
No description provided.