Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1277

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 54 additions & 1 deletion src/main/java/core/basesyntax/SalaryInfo.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,59 @@

public class SalaryInfo {
public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) {
return null;
int[] dateFromArr = getDateInArrayIntegerFormat(dateFrom);
int[] dateToArr = getDateInArrayIntegerFormat(dateTo);

StringBuilder outputBuilder = new StringBuilder(
"Report for period " + dateFrom + " - " + dateTo);

for (String name : names) {
int salaryCounter = 0;
outputBuilder.append("\n");

for (String info : data) {
String[] infoArr = info.split(" ");

if (infoArr[1].equals(name)) {
int[] dateEmploy = getDateInArrayIntegerFormat(infoArr[0]);

if (workingUpToDate(dateEmploy, dateFromArr, dateToArr)) {
salaryCounter += Integer.parseInt(infoArr[2])
* Integer.parseInt(infoArr[3]);
}
}
}

outputBuilder
.append(name)
.append(" - ")
.append(salaryCounter);
}

return outputBuilder.toString();
}

private int[] getDateInArrayIntegerFormat(String date) {
int[] dateInArrayInteger = new int[3];
String[] dateInArrayString = date.split("\\.");

for (int i = 0; i < dateInArrayInteger.length; i++) {
dateInArrayInteger[i] = Integer.parseInt(dateInArrayString[i]);
}

return dateInArrayInteger;
}

private boolean workingUpToDate(int[] dateEmploy, int[] dateSalaryFrom, int[] dateSalaryTo) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is dateEmploy? Please try to write more meaningful names

if (dateEmploy[2] >= dateSalaryFrom[2] && dateEmploy[2] <= dateSalaryTo[2]) {
if (dateEmploy[1] >= dateSalaryFrom[1] && dateEmploy[1] <= dateSalaryTo[1]) {
return !(dateEmploy[1] == dateSalaryFrom[1]
&& dateEmploy[0] < dateSalaryFrom[0])
&& !(dateEmploy[1] == dateSalaryTo[1]
&& dateEmploy[0] > dateSalaryTo[0]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use constants for such indexes.
It is easier to read date[INDEX_OF_DATE] instead of date[0] and so on

}
}

return false;
}
}
Loading