Solutionn with: two for loops, function which check the date and can throw ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat. #1320

B4rt1omiej · 2024-08-27T18:22:28Z

No description provided.

…throw ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat.

mateacademy-ai-mentor

Hey there! 👋 It looks like there are a few important improvements to be made regarding date handling, formatting, and code style. While these might not be breaking changes, they are essential for ensuring your code is up-to-date with modern Java practices and is as clean and efficient as possible. Let's tidy up those date formats and keep the code style sharp! 😊👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-08-27T18:23:02Z

src/main/java/core/basesyntax/SalaryInfo.java

+import java.text.ParseException;
+import java.text.SimpleDateFormat;
+import java.util.Date;


Use LocalDate instead of Date. The Date class is outdated and has been replaced with the more modern and robust java.time (JSR-310) package in Java 8. Here is some background why you should use it primarily: https://www.baeldung.com/migrating-to-java-8-date-time-api.

mateacademy-ai-mentor · 2024-08-27T18:23:02Z

src/main/java/core/basesyntax/SalaryInfo.java

+    public boolean dateComparator(String data, String dataFrom, String dataTo) {
+        SimpleDateFormat format = new SimpleDateFormat("dd.MM.yyyy");
+        try {
+            Date date = format.parse(data);
+            Date dateFrom = format.parse(dataFrom);
+            Date dateTo = format.parse(dataTo);
+            if (date.after(dateFrom) && date.before(dateTo)
+                    || date.equals(dateFrom) || date.equals(dateTo)) {
+                return true;
+            }
+        } catch (ParseException ex) {
+            System.out.println("Problem with data" + ex);
+        }
+        return false;
    }


If you create a formatter, make it a constant field. Since you're using the SimpleDateFormat in the dateComparator method, you should define it as a static final field in the class to avoid creating a new instance every time the method is called. This will also help with thread safety, as SimpleDateFormat is not thread-safe.

mateacademy-ai-mentor · 2024-08-27T18:23:02Z

src/main/java/core/basesyntax/SalaryInfo.java

+    public boolean dateComparator(String data, String dataFrom, String dataTo) {
+        SimpleDateFormat format = new SimpleDateFormat("dd.MM.yyyy");
+        try {
+            Date date = format.parse(data);
+            Date dateFrom = format.parse(dataFrom);
+            Date dateTo = format.parse(dataTo);
+            if (date.after(dateFrom) && date.before(dateTo)
+                    || date.equals(dateFrom) || date.equals(dateTo)) {
+                return true;
+            }
+        } catch (ParseException ex) {
+            System.out.println("Problem with data" + ex);
+        }
+        return false;
    }


Don’t begin method implementation with an empty line. The dateComparator method starts with an empty line which is unnecessary and should be removed.

mateacademy-ai-mentor · 2024-08-27T18:23:02Z

src/main/java/core/basesyntax/SalaryInfo.java

 public class SalaryInfo {
    public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) {
-        return null;
+        StringBuilder result = new StringBuilder();
+        result.append("Report for period ").append(dateFrom).append(" - ").append(dateTo);
+
+        for (String name : names) {
+            int salary = 0;
+            for (String datum : data) {
+                String[] parts = datum.split(" ");
+                int hours = Integer.parseInt(parts[2]);
+                int income = Integer.parseInt(parts[3]);
+                if (parts[1].equals(name) && dateComparator(parts[0], dateFrom, dateTo)) {
+                    salary += hours * income;
+                }
+            }
+            result.append(System.lineSeparator()).append(name).append(" - ").append(salary);
+        }
+
+        return String.valueOf(result);
+    }
+
+    public boolean dateComparator(String data, String dataFrom, String dataTo) {
+        SimpleDateFormat format = new SimpleDateFormat("dd.MM.yyyy");
+        try {
+            Date date = format.parse(data);
+            Date dateFrom = format.parse(dataFrom);
+            Date dateTo = format.parse(dataTo);
+            if (date.after(dateFrom) && date.before(dateTo)
+                    || date.equals(dateFrom) || date.equals(dateTo)) {
+                return true;
+            }
+        } catch (ParseException ex) {
+            System.out.println("Problem with data" + ex);
+        }
+        return false;
    }


Don't use an empty line to start the class implementation. Remove the redundant empty line at the beginning of the SalaryInfo class definition.

mateacademy-ai-mentor · 2024-08-27T18:23:02Z

src/main/java/core/basesyntax/SalaryInfo.java

+        StringBuilder result = new StringBuilder();
+        result.append("Report for period ").append(dateFrom).append(" - ").append(dateTo);


Use StringBuilder instead of String concatenation in loops. Although it's not inside a loop here, it's a good practice to use StringBuilder for assembling strings over multiple operations.

mateacademy-ai-mentor · 2024-08-27T18:23:02Z

src/main/java/core/basesyntax/SalaryInfo.java

+            result.append(System.lineSeparator()).append(name).append(" - ").append(salary);
+        }
+
+        return String.valueOf(result);


There's no need to call String.valueOf on a StringBuilder instance. StringBuilder's toString method provides the necessary functionality to convert it to a String.

mateacademy-ai-mentor · 2024-08-27T18:23:02Z

src/main/java/core/basesyntax/SalaryInfo.java

+            if (date.after(dateFrom) && date.before(dateTo)
+                    || date.equals(dateFrom) || date.equals(dateTo)) {


The condition can be simplified by using the !date.before(dateFrom) and !date.after(dateTo) checks, which cover the inclusive range between dateFrom and dateTo.

mateacademy-ai-mentor · 2024-08-27T18:23:02Z

src/main/java/core/basesyntax/SalaryInfo.java

+                return true;
+            }
+        } catch (ParseException ex) {
+            System.out.println("Problem with data" + ex);


When logging an exception, it's important to include the stack trace for debugging purposes. Consider using ex.printStackTrace() instead of just printing the message.

…hrow ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat changed from Data to LocalData and simplified function.

MateuszRostek

Nice try! See some advice and implement it.

MateuszRostek · 2024-08-28T17:28:24Z

src/main/java/core/basesyntax/SalaryInfo.java

+    }
+
+    static final boolean dateComparator(String data, String dataFrom, String dataTo) {
+        DateTimeFormatter format = DateTimeFormatter.ofPattern(("dd.MM.yyyy"));


MateuszRostek · 2024-08-28T17:29:04Z

src/main/java/core/basesyntax/SalaryInfo.java

+            result.append(System.lineSeparator()).append(name).append(" - ").append(salary);
+        }
+
+        return new String(result);


How i can return a stringBuilder in "public string" class if i didn' change it into string?

As AI Mentor said, use .toString() method on the stringBuilder.

MateuszRostek · 2024-08-28T17:29:31Z

src/main/java/core/basesyntax/SalaryInfo.java

+        return new String(result);
+    }
+
+    static final boolean dateComparator(String data, String dataFrom, String dataTo) {


missing private access modifier

MateuszRostek · 2024-08-28T17:30:59Z

src/main/java/core/basesyntax/SalaryInfo.java

+                String[] parts = datum.split(" ");
+                int hours = Integer.parseInt(parts[2]);
+                int income = Integer.parseInt(parts[3]);
+                if (parts[1].equals(name) && dateComparator(parts[0], dateFrom, dateTo)) {


Do not use magic numbers/string literals, create constans for 0, 1, 2, 3 and " ".

…hrow ParseException if something isn't right, StringBuilder contained solution and dataFormat. Data changed to LocalData and simplified function. Private access added and constants are presents.

MateuszRostek

Please read about constants in java and how to create them:

https://www.javatpoint.com/java-constant

MateuszRostek · 2024-08-28T18:00:19Z

src/main/java/core/basesyntax/SalaryInfo.java

+    }
+
+    private static final boolean dateComparator(String data, String dataFrom, String dataTo) {
+        DateTimeFormatter format = DateTimeFormatter.ofPattern(("dd.MM.yyyy"));


https://www.javatpoint.com/java-constant

MateuszRostek · 2024-08-28T18:00:26Z

src/main/java/core/basesyntax/SalaryInfo.java

+            String regexSymbol = " ";
+            for (String datum : data) {
+                String[] parts = datum.split(regexSymbol);
+                int dateIndex = 0;
+                int nameIndex = 1;
+                int hoursIndex = 2;
+                int incomeIndex = 3;


https://www.javatpoint.com/java-constant

Solutionn with: two for loops, function which check the date and can …

3f8bbd1

…throw ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat.

mateacademy-ai-mentor suggested changes Aug 27, 2024

View reviewed changes

Solution with: two for loops, function which check the date and can t…

8fd773f

…hrow ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat changed from Data to LocalData and simplified function.

B4rt1omiej requested a review from mateacademy-ai-mentor August 28, 2024 06:44

MateuszRostek suggested changes Aug 28, 2024

View reviewed changes

Solution with: two for loops, function which check the date and can t…

c97c82e

…hrow ParseException if something isn't right, StringBuilder contained solution and dataFormat. Data changed to LocalData and simplified function. Private access added and constants are presents.

B4rt1omiej requested a review from MateuszRostek August 28, 2024 17:56

MateuszRostek approved these changes Aug 28, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solutionn with: two for loops, function which check the date and can throw ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat. #1320

Solutionn with: two for loops, function which check the date and can throw ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat. #1320

B4rt1omiej commented Aug 27, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Aug 27, 2024

mateacademy-ai-mentor Aug 27, 2024

mateacademy-ai-mentor Aug 27, 2024

mateacademy-ai-mentor Aug 27, 2024

mateacademy-ai-mentor Aug 27, 2024

mateacademy-ai-mentor Aug 27, 2024

mateacademy-ai-mentor Aug 27, 2024

mateacademy-ai-mentor Aug 27, 2024

MateuszRostek left a comment

MateuszRostek Aug 28, 2024

MateuszRostek Aug 28, 2024

B4rt1omiej Aug 28, 2024

MateuszRostek Aug 28, 2024

MateuszRostek Aug 28, 2024

MateuszRostek Aug 28, 2024 •

edited

Loading

MateuszRostek left a comment

MateuszRostek Aug 28, 2024

MateuszRostek Aug 28, 2024

		StringBuilder result = new StringBuilder();
		result.append("Report for period ").append(dateFrom).append(" - ").append(dateTo);

		if (date.after(dateFrom) && date.before(dateTo)
		\|\| date.equals(dateFrom) \|\| date.equals(dateTo)) {

Solutionn with: two for loops, function which check the date and can throw ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat. #1320

Are you sure you want to change the base?

Solutionn with: two for loops, function which check the date and can throw ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat. #1320

Conversation

B4rt1omiej commented Aug 27, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MateuszRostek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MateuszRostek Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

MateuszRostek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MateuszRostek Aug 28, 2024 •

edited

Loading