-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solutionn with: two for loops, function which check the date and can throw ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat. #1320
Open
B4rt1omiej
wants to merge
3
commits into
mate-academy:master
Choose a base branch
from
B4rt1omiej:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
3f8bbd1
Solutionn with: two for loops, function which check the date and can …
B4rt1omiej 8fd773f
Solution with: two for loops, function which check the date and can t…
B4rt1omiej c97c82e
Solution with: two for loops, function which check the date and can t…
B4rt1omiej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,41 @@ | ||
package core.basesyntax; | ||
|
||
import java.time.LocalDate; | ||
import java.time.format.DateTimeFormatter; | ||
|
||
public class SalaryInfo { | ||
public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
return null; | ||
StringBuilder result = new StringBuilder(); | ||
result.append("Report for period ").append(dateFrom).append(" - ").append(dateTo); | ||
|
||
for (String name : names) { | ||
int salary = 0; | ||
String regexSymbol = " "; | ||
for (String datum : data) { | ||
String[] parts = datum.split(regexSymbol); | ||
int dateIndex = 0; | ||
int nameIndex = 1; | ||
int hoursIndex = 2; | ||
int incomeIndex = 3; | ||
Comment on lines
+13
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
int hours = Integer.parseInt(parts[hoursIndex]); | ||
int income = Integer.parseInt(parts[incomeIndex]); | ||
if (parts[nameIndex].equals(name) | ||
&& dateComparator(parts[dateIndex], dateFrom, dateTo)) { | ||
salary += hours * income; | ||
} | ||
} | ||
result.append(System.lineSeparator()).append(name).append(" - ").append(salary); | ||
} | ||
|
||
return result.toString(); | ||
} | ||
|
||
private static final boolean dateComparator(String data, String dataFrom, String dataTo) { | ||
DateTimeFormatter format = DateTimeFormatter.ofPattern(("dd.MM.yyyy")); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
LocalDate date = LocalDate.parse(data, format); | ||
LocalDate dateFrom = LocalDate.parse(dataFrom, format); | ||
LocalDate dateTo = LocalDate.parse(dataTo, format); | ||
return !date.isBefore(dateFrom) && !date.isAfter(dateTo); | ||
|
||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use StringBuilder instead of String concatenation in loops. Although it's not inside a loop here, it's a good practice to use StringBuilder for assembling strings over multiple operations.