Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solutionn with: two for loops, function which check the date and can throw ParseExcepion if something isn't right, StringBuilder contained solution and dataFormat. #1320

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion src/main/java/core/basesyntax/SalaryInfo.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,41 @@
package core.basesyntax;

import java.time.LocalDate;
import java.time.format.DateTimeFormatter;

public class SalaryInfo {
public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) {
return null;
StringBuilder result = new StringBuilder();
result.append("Report for period ").append(dateFrom).append(" - ").append(dateTo);
Comment on lines +8 to +9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use StringBuilder instead of String concatenation in loops. Although it's not inside a loop here, it's a good practice to use StringBuilder for assembling strings over multiple operations.


for (String name : names) {
int salary = 0;
String regexSymbol = " ";
for (String datum : data) {
String[] parts = datum.split(regexSymbol);
int dateIndex = 0;
int nameIndex = 1;
int hoursIndex = 2;
int incomeIndex = 3;
Comment on lines +13 to +19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int hours = Integer.parseInt(parts[hoursIndex]);
int income = Integer.parseInt(parts[incomeIndex]);
if (parts[nameIndex].equals(name)
&& dateComparator(parts[dateIndex], dateFrom, dateTo)) {
salary += hours * income;
}
}
result.append(System.lineSeparator()).append(name).append(" - ").append(salary);
}

return result.toString();
}

private static final boolean dateComparator(String data, String dataFrom, String dataTo) {
DateTimeFormatter format = DateTimeFormatter.ofPattern(("dd.MM.yyyy"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LocalDate date = LocalDate.parse(data, format);
LocalDate dateFrom = LocalDate.parse(dataFrom, format);
LocalDate dateTo = LocalDate.parse(dataTo, format);
return !date.isBefore(dateFrom) && !date.isAfter(dateTo);

}
}
Loading