Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #584

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

solution #584

wants to merge 6 commits into from

Conversation

YevhenPodobedo
Copy link

vadiimvooo
vadiimvooo suggested changes Jun 12, 2024
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but there are a few things to fix:

  1. Remove this empty white line after footer.
    image
  2. If you want to make fixed header, do it with logo as well
    image
  3. Make logo as link which will lead to main page.

TarasHoliuk
TarasHoliuk approved these changes Jun 13, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Nice animations 🔥
Great job - approved ✔️

@YevhenPodobedo
Copy link
Author

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarasHoliuk TarasHoliuk TarasHoliuk approved these changes

@vadiimvooo vadiimvooo Awaiting requested review from vadiimvooo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YevhenPodobedo @TarasHoliuk @vadiimvooo