Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #584

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .htmlnanorc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"minifySvg": false
}
30 changes: 15 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,21 @@ Implement landing page according to [Figma design](https://www.figma.com/file/dY


## Github flow
1. **Fork** the repo.
2. **Clone** the forked one. (The project link should have your name but not `mate-academy`)
3. Run `npm install` (or just `npm i`).
4. Run `npm start`.
5. Open one more terminal window for the next steps.
6. `git checkout -b develop` - to create new branch and switch on it.
7. Write you code in `src` folder.
8. Run `npm run lint` and fix code style errors.
9. Run `npm run deploy` to deploy your solution to `gh-pages`.
10. `git add . && git commit -m 'solution'` to save your changes.
11. `git push origin develop` - to send you code for PR.
12. Create a Pull Request (PR) from your branch `develop` to branch `master` of original repo.
13. Replace `<your_account>` with your Github username in the
[DEMO LINK](https://<your_account>.github.io/layout_creativeBakery/).
14. Copy `DEMO LINK` to the PR description.
1. **Fork** the repo.
2. **Clone** the forked one. (The project link should have your name but not `mate-academy`)
3. Run `npm install` (or just `npm i`).
4. Run `npm start`.
5. Open one more terminal window for the next steps.
6. `git checkout -b develop` - to create new branch and switch on it.
7. Write you code in `src` folder.
8. Run `npm run lint` and fix code style errors.
9. Run `npm run deploy` to deploy your solution to `gh-pages`.
10. `git add . && git commit -m 'solution'` to save your changes.
11. `git push origin develop` - to send you code for PR.
12. Create a Pull Request (PR) from your branch `develop` to branch `master` of original repo.
13. Replace `<your_account>` with your Github username in the
[DEMO LINK](https://YevhenPodobedo.github.io/layout_creativeBakery/).
14. Copy `DEMO LINK` to the PR description.

> To update you PR repeat steps 7-11.

Expand Down
30 changes: 15 additions & 15 deletions checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,23 @@

## Tech review

1. Add [favicon](http://joxi.ru/MAjagDPid4DEl2)
2. Add a smooth scroll for the whole page (`scroll-behavior: smooth;`)
3. Logos in header and footer should be links to home page
4. Make sure when you click on logo there is no 404 error (Use `href="#"` in `anchor tag`)
5. Pictures in the blocks "What We Bake" should be ***animated*** on hover
6. All interactive elements (*links, buttons, pictures, icons*) ***should have a hover effect and cursor pointer***. User must intuitively understand that he can interact with them
1. Add [favicon](http://joxi.ru/MAjagDPid4DEl2)
2. Add a smooth scroll for the whole page (`scroll-behavior: smooth;`)
3. Logos in header and footer should be links to home page
4. Make sure when you click on logo there is no 404 error (Use `href="#"` in `anchor tag`)
5. Pictures in the blocks "What We Bake" should be ***animated*** on hover
6. All interactive elements (*links, buttons, pictures, icons*) ***should have a hover effect and cursor pointer***. User must intuitively understand that he can interact with them


## HR review

1. To make it clear to the recruiter what exactly this landing page is, it is better to give the whole web page the title “Creative Bakery”
2. A landing page is implemented strictly according to the design in Figma
3. Links in the header and footer menus should lead to the corresponding blocks of the landing page
4. ***The speed of animations is the same throughout the landing page*** (for example, increasing when hovering or moving blocks when scrolling)
5. Make sure everything looks neat on mobile and without horizontal scrolling
6. The “learn more” button leads to the “About us” block
7. Buttons "order" lead to the contact in footer
8. All the social icons in the footer should be clickable and open the social networks in a new tab
9. Menu footer buttons when clicked should lead to the relevant blocks of the landing page
1. To make it clear to the recruiter what exactly this landing page is, it is better to give the whole web page the title “Creative Bakery”
2. A landing page is implemented strictly according to the design in Figma
3. Links in the header and footer menus should lead to the corresponding blocks of the landing page
4. ***The speed of animations is the same throughout the landing page*** (for example, increasing when hovering or moving blocks when scrolling)
5. Make sure everything looks neat on mobile and without horizontal scrolling
6. The “learn more” button leads to the “About us” block
7. Buttons "order" lead to the contact in footer
8. All the social icons in the footer should be clickable and open the social networks in a new tab
9. Menu footer buttons when clicked should lead to the relevant blocks of the landing page

Loading
Loading