Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search bar #4548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

search bar #4548

wants to merge 1 commit into from

Conversation

natalia646
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the HTML file! While there are some minor formatting and spacing issues, they don't impact the functionality. Keep up the good work and consider the feedback for future improvements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<form
class="form form--big"
data-qa="big"
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no blank line between the opening

tag and its child elements. According to the checklist, blank lines shouldn't be between parent and child elements.

class="input input--big"
data-qa="keypress"
/>
</form>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a blank line between the closing tag of the first form and the opening

tag of the second form. According to the checklist, add empty lines between multiline sibling blocks of HTML.

@@ -1 +1,77 @@
/* add styles here */
@font-face {
font-family: Arial;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-family name 'Arial' is being redefined in the @font-face rule. Consider using a unique name for the custom font to avoid conflicts with the standard Arial font.

}

@font-face {
font-family: Arial;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-family name 'Arial' is being redefined in the @font-face rule. Consider using a unique name for the custom font to avoid conflicts with the standard Arial font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants