Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search bar #4548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

search bar #4548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,29 @@
href="style.css"
/>
</head>
<body>
<input
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
/>
<body class="page">
<form
class="form form--big"
data-qa="big"
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no blank line between the opening

tag and its child elements. According to the checklist, blank lines shouldn't be between parent and child elements.

<input
type="text"
placeholder="Try “Los Angeles“"
class="input input--big"
data-qa="keypress"
/>
</form>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a blank line between the closing tag of the first form and the opening

tag of the second form. According to the checklist, add empty lines between multiline sibling blocks of HTML.

<input
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
/>
<form
class="form"
data-qa="small"
>
<input
type="text"
placeholder="Try “Los Angeles“"
class="input input--small"
data-qa="hover"
/>
</form>
</body>
</html>
78 changes: 77 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,77 @@
/* add styles here */
@font-face {
font-family: Arial;
src: url(fonts/Avenir-Book.ttf);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-family name 'Arial' is being redefined in the @font-face rule. Consider using a unique name for the custom font to avoid conflicts with the standard Arial font.

font-weight: 300;
}

@font-face {
font-family: Arial;
src: url(fonts/Avenir-Heavy.ttf);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-family name 'Arial' is being redefined in the @font-face rule. Consider using a unique name for the custom font to avoid conflicts with the standard Arial font.

font-weight: 900;
}

.page {
--bg-color: #fff;
--border-color: #e1e7ed;
--box-shadow-active: #00000040;
--txt-color: #3d4e61;

padding: 0;
margin-top: 0;
display: flex;
flex-direction: column;
row-gap: 20px;
}

.form--big {
margin-top: 20px;
}

.input {
width: 100%;
background: url('./images/Search.svg') no-repeat;
box-sizing: border-box;
background-size: contain;
border-radius: 4px;
background-color: var(--bg-color);
border: 1px solid var(--border-color);
font-weight: 300;
box-shadow: 0 1px 8px 0 #3d4e611a;
color: var(--txt-color);
font-family: Arial, sans-serif;
}

.input--big {
min-height: 70px;
background-size: 19px;
background-position: 26px center;
padding-left: 62px;
font-size: 16px;
line-height: 22px;
}

.input--small {
min-height: 42px;
background-size: 11px;
background-position: 13px center;
padding-left: 33px;
font-size: 14px;
line-height: 19px;
}

.input:hover {
box-shadow: 0 4px 4px 0 var(--box-shadow-active);
}

.input:focus {
background: linear-gradient(180deg, var(--bg-color) 0%, #f6f6f7 100%);
filter: drop-shadow(0 4px 4px var(--box-shadow-active));
font-weight: 900;
outline: none;
}

.input::placeholder {
font-family: Arial, sans-serif;
font-weight: 300;
color: var(--txt-color);
}
Loading