New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4971

Open

thshnhta wants to merge 1 commit into mate-academy:master from thshnhta:develop

thshnhta commented Oct 17, 2024


          add task solution

440a64d

mateacademy-ai-mentor approved these changes

View reviewed changes

mateacademy-ai-mentor left a comment

Great job on structuring the HTML file with semantic tags! While there are some minor formatting issues, they don't impact the core functionality. Keep up the good work and consider the feedback for future improvements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html

		@@ -13,6 +13,47 @@
		/>

mateacademy-ai-mentor Oct 17, 2024

There should be an empty line between the tag and the closing tag to improve readability, as they are sibling elements.

src/index.html

Comment on lines 14 to 15

		</head>
		<body>

mateacademy-ai-mentor Oct 17, 2024

There should be an empty line between the closing tag and the opening tag to improve readability, as they are sibling elements.

src/index.html

Comment on lines +22 to +23

		</ul>
		<ul class="stars stars--1">

mateacademy-ai-mentor Oct 17, 2024

There should be an empty line between the closing tag and the opening

src/index.html

Comment on lines +29 to +30

		</ul>
		<ul class="stars stars--2">

mateacademy-ai-mentor Oct 17, 2024

There should be an empty line between the closing tag and the opening

src/index.html

Comment on lines +36 to +37

		</ul>
		<ul class="stars stars--3">

mateacademy-ai-mentor Oct 17, 2024

There should be an empty line between the closing tag and the opening

src/style.css

+                background-image: url(./images/star-active.svg);
+              }
+              .stars--1 :nth-child(-n + 1) {

mateacademy-ai-mentor Oct 17, 2024

Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.

src/style.css

+                background-image: url(./images/star-active.svg);
+              }
+              .stars--2 :nth-child(-n + 2) {

mateacademy-ai-mentor Oct 17, 2024

Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.

src/style.css

+                background-image: url(./images/star-active.svg);
+              }
+              .stars--3 :nth-child(-n + 3) {

mateacademy-ai-mentor Oct 17, 2024

Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.

src/style.css

+                background-image: url(./images/star-active.svg);
+              }
+              .stars--4 :nth-child(-n + 4) {

mateacademy-ai-mentor Oct 17, 2024

Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.

src/style.css

+                background-image: url(./images/star-active.svg);
+              }
+              .stars--5 :nth-child(-n + 5) {

mateacademy-ai-mentor Oct 17, 2024

Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet