-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4971
base: master
Are you sure you want to change the base?
add task solution #4971
Conversation
thshnhta
commented
Oct 17, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on structuring the HTML file with semantic tags! While there are some minor formatting issues, they don't impact the core functionality. Keep up the good work and consider the feedback for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -13,6 +13,47 @@ | |||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an empty line between the tag and the closing tag to improve readability, as they are sibling elements.
</head> | ||
<body> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an empty line between the closing tag and the opening tag to improve readability, as they are sibling elements.
</ul> | ||
<ul class="stars stars--1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an empty line between the closing tag and the opening
- tag to improve readability, as they are sibling elements.
</ul> | ||
<ul class="stars stars--2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an empty line between the closing tag and the opening
- tag to improve readability, as they are sibling elements.
</ul> | ||
<ul class="stars stars--3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an empty line between the closing tag and the opening
- tag to improve readability, as they are sibling elements.
background-image: url(./images/star-active.svg); | ||
} | ||
|
||
.stars--1 :nth-child(-n + 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.
background-image: url(./images/star-active.svg); | ||
} | ||
|
||
.stars--2 :nth-child(-n + 2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.
background-image: url(./images/star-active.svg); | ||
} | ||
|
||
.stars--3 :nth-child(-n + 3) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.
background-image: url(./images/star-active.svg); | ||
} | ||
|
||
.stars--4 :nth-child(-n + 4) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.
background-image: url(./images/star-active.svg); | ||
} | ||
|
||
.stars--5 :nth-child(-n + 5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability.