-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4971
base: master
Are you sure you want to change the base?
add task solution #4971
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,47 @@ | |
/> | ||
</head> | ||
<body> | ||
Comment on lines
14
to
15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should be an empty line between the closing tag and the opening tag to improve readability, as they are sibling elements. |
||
<h1>Stars</h1> | ||
<ul class="stars stars--0"> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
</ul> | ||
<ul class="stars stars--1"> | ||
Comment on lines
+22
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should be an empty line between the closing tag and the opening
|
||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
</ul> | ||
<ul class="stars stars--2"> | ||
Comment on lines
+29
to
+30
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should be an empty line between the closing tag and the opening
|
||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
</ul> | ||
<ul class="stars stars--3"> | ||
Comment on lines
+36
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should be an empty line between the closing tag and the opening
|
||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
</ul> | ||
<ul class="stars stars--4"> | ||
Comment on lines
+43
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should be an empty line between the closing tag and the opening
|
||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
</ul> | ||
<ul class="stars stars--5"> | ||
Comment on lines
+50
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should be an empty line between the closing tag and the opening
|
||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
</ul> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,47 @@ | ||
/* add styles here */ | ||
body { | ||
margin: 0; | ||
padding: 0; | ||
} | ||
|
||
.stars { | ||
display: flex; | ||
padding-left: 0; | ||
margin: 0; | ||
list-style-type: none; | ||
} | ||
|
||
.stars__star { | ||
display: flex; | ||
background: url(./images/star.svg) center no-repeat; | ||
height: 16px; | ||
width: 16px; | ||
margin-right: 4px; | ||
} | ||
|
||
.stars__star:last-child { | ||
margin-right: 0; | ||
} | ||
|
||
.stars--0 :nth-child(-n + 0) { | ||
background-image: url(./images/star-active.svg); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability. |
||
} | ||
|
||
.stars--1 :nth-child(-n + 1) { | ||
background-image: url(./images/star-active.svg); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability. |
||
} | ||
|
||
.stars--2 :nth-child(-n + 2) { | ||
background-image: url(./images/star-active.svg); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability. |
||
} | ||
|
||
.stars--3 :nth-child(-n + 3) { | ||
background-image: url(./images/star-active.svg); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability. |
||
} | ||
|
||
.stars--4 :nth-child(-n + 4) { | ||
background-image: url(./images/star-active.svg); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability. |
||
} | ||
|
||
.stars--5 :nth-child(-n + 5) { | ||
background-image: url(./images/star-active.svg); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid using tag names for styling. Instead of using a space before ':nth-child', consider using a class or another selector to target the element. This will improve performance and maintainability. |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an empty line between the tag and the closing tag to improve readability, as they are sibling elements.