Updated solution #1698
Open
Updated solution #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2024 17:09
Dimosphen1
suggested changes
Oct 8, 2024
app/main.py
Outdated
Comment on lines
12
to
23
| return { | ||
| "errors" : [], | ||
| "path" : file_path, | ||
| "status" : "passed" | ||
| } if errors == [] else { | ||
| "errors" : [ | ||
| format_linter_error(error) | ||
| for error in errors | ||
| ], | ||
| "path" : file_path, | ||
| "status" : "failed" | ||
| } |
There was a problem hiding this comment.
Please, use if condition in a value for errors key instead of forming two dicts here
There was a problem hiding this comment.
But statuses at these dicts are different too. OR if double "if" condition like this:
def format_single_linter_file(file_path: str, errors: list) -> dict:
return {
"errors" : [] if errors == [] else
[
format_linter_error(error)
for error in errors
],
"path" : file_path,
"status" : "passed" if errors == [] else"failed"
}
is possible?
viktoria-rybenchuk
suggested changes
Oct 8, 2024
app/main.py
Outdated
| for error in errors | ||
| ], | ||
| "path" : file_path, | ||
| "status" : "passed" if errors == [] else "failed" |
There was a problem hiding this comment.
you can check if errors, no need to compare with empty list
pavlopro
suggested changes
Oct 8, 2024
app/main.py
Outdated
| # write your code here | ||
| pass | ||
| return { | ||
| "errors" : [] if not errors else |
There was a problem hiding this comment.
Pplease, simplify this to [format_linter_error(error) for error in errors]
added 2 commits
October 8, 2024 15:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.