-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated solution #1698
base: master
Are you sure you want to change the base?
Updated solution #1698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several changes were requested
app/main.py
Outdated
return { | ||
"errors" : [], | ||
"path" : file_path, | ||
"status" : "passed" | ||
} if errors == [] else { | ||
"errors" : [ | ||
format_linter_error(error) | ||
for error in errors | ||
], | ||
"path" : file_path, | ||
"status" : "failed" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use if condition in a value for errors
key instead of forming two dicts here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But statuses at these dicts are different too. OR if double "if" condition like this:
def format_single_linter_file(file_path: str, errors: list) -> dict:
return {
"errors" : [] if errors == [] else
[
format_linter_error(error)
for error in errors
],
"path" : file_path,
"status" : "passed" if errors == [] else"failed"
}
is possible?
app/main.py
Outdated
for error in errors | ||
], | ||
"path" : file_path, | ||
"status" : "passed" if errors == [] else "failed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can check if errors, no need to compare with empty list
app/main.py
Outdated
# write your code here | ||
pass | ||
return { | ||
"errors" : [] if not errors else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pplease, simplify this to [format_linter_error(error) for error in errors]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
No description provided.