Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated solution #1698

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Updated solution #1698

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a0ae539
Solution
Oct 7, 2024
be2b63e
Updated solution
Oct 8, 2024
eee05c5
Another update
Oct 8, 2024
095805c
Guess last update
Oct 8, 2024
706e5c5
...
Oct 8, 2024
5287941
Errors call fix
Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,30 @@
def format_linter_error(error: dict) -> dict:
# write your code here
pass
return {
"line" : error["line_number"],
"column" : error["column_number"],
"message" : error["text"],
"name" : error["code"],
"source" : "flake8"
}


def format_single_linter_file(file_path: str, errors: list) -> dict:
# write your code here
pass
return {
"errors" : [],
"path" : file_path,
"status" : "passed"
} if errors == [] else {
"errors" : [
format_linter_error(error)
for error in errors
],
"path" : file_path,
"status" : "failed"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use if condition in a value for errors key instead of forming two dicts here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But statuses at these dicts are different too. OR if double "if" condition like this:

def format_single_linter_file(file_path: str, errors: list) -> dict:
return {
"errors" : [] if errors == [] else
[
format_linter_error(error)
for error in errors
],
"path" : file_path,
"status" : "passed" if errors == [] else"failed"
}

is possible?



def format_linter_report(linter_report: dict) -> list:
# write your code here
pass
return [
format_single_linter_file(file_path, errors)
for file_path, errors in linter_report.items()
]
Loading