Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1727

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1727

wants to merge 2 commits into from

Conversation

Ryu-Tora
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the pull request! 🎉 While there's a minor suggestion to avoid code duplication by using the format_linter_error function, it doesn't impact the functionality. Keep up the good work and consider refactoring for cleaner code in the future!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +15 to +19
"line": error["line_number"],
"column": error["column_number"],
"message": error["text"],
"name": error["code"],
"source": "flake8"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block of code is duplicated in the format_linter_error function. Consider using the format_linter_error function to avoid repetition and adhere to the 'Don't Repeat Yourself' principle.

app/main.py Outdated
Comment on lines 32 to 37
{
"line": mistake["line_number"],
"column": mistake["column_number"],
"message": mistake["text"],
"name": mistake["code"],
"source": "flake8"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block of code is also duplicated in the format_linter_error function. Consider using the format_linter_error function to avoid repetition and adhere to the 'Don't Repeat Yourself' principle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants