Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1727

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1727

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a76d6ac
Solution
Ryu-Tora Oct 20, 2024
96612d7
Remake
Ryu-Tora Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 38 additions & 6 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,45 @@
def format_linter_error(error: dict) -> dict:
# write your code here
pass
return {
"line": error["line_number"],
"column": error["column_number"],
"message": error["text"],
"name": error["code"],
"source": "flake8"
}


def format_single_linter_file(file_path: str, errors: list) -> dict:
# write your code here
pass
return {
"errors": [
{
"line": error["line_number"],
"column": error["column_number"],
"message": error["text"],
"name": error["code"],
"source": "flake8"
Comment on lines +15 to +19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block of code is duplicated in the format_linter_error function. Consider using the format_linter_error function to avoid repetition and adhere to the 'Don't Repeat Yourself' principle.

}
for error in errors
] if errors else [],
"path": file_path,
"status": "failed" if errors else "passed",
}


def format_linter_report(linter_report: dict) -> list:
# write your code here
pass
return [
{
"errors": [
{
"line": mistake["line_number"],
"column": mistake["column_number"],
"message": mistake["text"],
"name": mistake["code"],
"source": "flake8"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block of code is also duplicated in the format_linter_error function. Consider using the format_linter_error function to avoid repetition and adhere to the 'Don't Repeat Yourself' principle.

}
for mistake in mistakes
] if mistakes else [],
"path": file_path,
"status": "failed" if mistakes else "passed",
}
for file_path, mistakes in linter_report.items()
]
Loading