Solution #1736
Open
Solution #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Great job on implementing the functions! 🎉 There's a small improvement you could make by adjusting the 'status' logic in format_single_linter_file to reflect whether there are errors or not. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| "errors": | ||
| [format_linter_error(separate_dict) for separate_dict in errors], | ||
| "path": file_path , | ||
| "status": "failed" |
There was a problem hiding this comment.
The 'status' is hardcoded to 'failed'. Consider checking if 'errors' is empty and set 'status' to 'passed' if there are no errors, similar to the logic used in the 'format_linter_report' function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.