Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,31 @@
def format_linter_error(error: dict) -> dict:
# write your code here
pass

return {
"line" : error["line_number"],
"column" : error["column_number"],
"message" : error["text"],
"name" : error["code"],
"source" : "flake8"
}


def format_single_linter_file(file_path: str, errors: list) -> dict:
# write your code here
pass

return {
"errors":
[format_linter_error(separate_dict) for separate_dict in errors],
"path": file_path ,
"status": "failed"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'status' is hardcoded to 'failed'. Consider checking if 'errors' is empty and set 'status' to 'passed' if there are no errors, similar to the logic used in the 'format_linter_report' function.

}


def format_linter_report(linter_report: dict) -> list:
# write your code here
pass

return [
{
"errors": [format_linter_error(error) for error in errors],
"path": file_path,
"status": "failed" if errors else "passed"
}
for file_path, errors in linter_report.items()
]
Loading